Add fix for comment-related whitespace rules by charliermarsh · Pull Request #9075 · astral-sh/ruff

charliermarsh · 2023-12-09T19:52:26Z

Closes #9067.

Closes #9068.

Closes #8119.

github-actions · 2023-12-09T20:04:50Z

`ruff-ecosystem` results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

ℹ️ ecosystem check detected linter changes. (+0 -1 violations, +20218 -0 fixes in 41 projects)

DisnakeDev/disnake (+0 -0 violations, +10 -0 fixes)

ruff check --no-cache --exit-zero --preview

- disnake/opus.py:76:1: E266 Too many leading `#` before block comment
+ disnake/opus.py:76:1: E266 [*] Too many leading `#` before block comment
- disnake/types/interactions.py:167:1: E266 Too many leading `#` before block comment
+ disnake/types/interactions.py:167:1: E266 [*] Too many leading `#` before block comment
- disnake/types/interactions.py:179:1: E266 Too many leading `#` before block comment
+ disnake/types/interactions.py:179:1: E266 [*] Too many leading `#` before block comment
- disnake/types/interactions.py:217:1: E266 Too many leading `#` before block comment
+ disnake/types/interactions.py:217:1: E266 [*] Too many leading `#` before block comment
- disnake/types/interactions.py:247:1: E266 Too many leading `#` before block comment
+ disnake/types/interactions.py:247:1: E266 [*] Too many leading `#` before block comment

alteryx/featuretools (+0 -0 violations, +8 -0 fixes)

ruff check --no-cache --exit-zero --preview

- docs/source/conf.py:297:5: E265 Block comment should start with `# `
+ docs/source/conf.py:297:5: E265 [*] Block comment should start with `# `
- docs/source/conf.py:299:5: E265 Block comment should start with `# `
+ docs/source/conf.py:299:5: E265 [*] Block comment should start with `# `
- docs/source/conf.py:301:5: E265 Block comment should start with `# `
+ docs/source/conf.py:301:5: E265 [*] Block comment should start with `# `
- docs/source/conf.py:303:5: E265 Block comment should start with `# `
+ docs/source/conf.py:303:5: E265 [*] Block comment should start with `# `

apache/airflow (+0 -0 violations, +14 -0 fixes)

ruff check --no-cache --exit-zero --preview --select ALL

- airflow/api_connexion/endpoints/forward_to_fab_endpoint.py:100:1: E266 Too many leading `#` before block comment
+ airflow/api_connexion/endpoints/forward_to_fab_endpoint.py:100:1: E266 [*] Too many leading `#` before block comment
- airflow/api_connexion/endpoints/forward_to_fab_endpoint.py:58:1: E266 Too many leading `#` before block comment
+ airflow/api_connexion/endpoints/forward_to_fab_endpoint.py:58:1: E266 [*] Too many leading `#` before block comment
- airflow/api_connexion/endpoints/forward_to_fab_endpoint.py:93:1: E266 Too many leading `#` before block comment
+ airflow/api_connexion/endpoints/forward_to_fab_endpoint.py:93:1: E266 [*] Too many leading `#` before block comment
... 1 additional changes omitted for rule E266
- airflow/providers/google/cloud/hooks/bigquery.py:1072:30: E262 Inline comment should start with `# `
+ airflow/providers/google/cloud/hooks/bigquery.py:1072:30: E262 [*] Inline comment should start with `# `
- airflow/providers/google/cloud/hooks/mlengine.py:595:39: E262 Inline comment should start with `# `
+ airflow/providers/google/cloud/hooks/mlengine.py:595:39: E262 [*] Inline comment should start with `# `
... 4 additional changes omitted for project

bokeh/bokeh (+0 -0 violations, +19098 -0 fixes)

ruff check --no-cache --exit-zero --preview --select ALL

- examples/basic/annotations/box_annotation.py:17:1: E265 Block comment should start with `# `
+ examples/basic/annotations/box_annotation.py:17:1: E265 [*] Block comment should start with `# `
- examples/basic/layouts/anscombe.py:52:1: E265 Block comment should start with `# `
+ examples/basic/layouts/anscombe.py:52:1: E265 [*] Block comment should start with `# `
- examples/basic/scatters/elements.py:32:75: E262 Inline comment should start with `# `
+ examples/basic/scatters/elements.py:32:75: E262 [*] Inline comment should start with `# `
- examples/integration/widgets/layout_multiple_widgets.py:44:5: E265 Block comment should start with `# `
+ examples/integration/widgets/layout_multiple_widgets.py:44:5: E265 [*] Block comment should start with `# `
- examples/integration/widgets/layout_multiple_widgets.py:45:5: E265 Block comment should start with `# `
+ examples/integration/widgets/layout_multiple_widgets.py:45:5: E265 [*] Block comment should start with `# `
- examples/integration/widgets/layout_multiple_widgets.py:46:5: E265 Block comment should start with `# `
+ examples/integration/widgets/layout_multiple_widgets.py:46:5: E265 [*] Block comment should start with `# `
- examples/integration/widgets/layout_multiple_widgets.py:47:5: E265 Block comment should start with `# `
+ examples/integration/widgets/layout_multiple_widgets.py:47:5: E265 [*] Block comment should start with `# `
- examples/integration/widgets/layout_multiple_widgets.py:49:5: E265 Block comment should start with `# `
+ examples/integration/widgets/layout_multiple_widgets.py:49:5: E265 [*] Block comment should start with `# `
- examples/integration/widgets/layout_multiple_widgets.py:50:5: E265 Block comment should start with `# `
+ examples/integration/widgets/layout_multiple_widgets.py:50:5: E265 [*] Block comment should start with `# `
... 18979 additional changes omitted for rule E265
- examples/plotting/checkout_form.py:21:62: E262 Inline comment should start with `# `
+ examples/plotting/checkout_form.py:21:62: E262 [*] Inline comment should start with `# `
- examples/plotting/checkout_form.py:22:55: E262 Inline comment should start with `# `
+ examples/plotting/checkout_form.py:22:55: E262 [*] Inline comment should start with `# `
- examples/reference/models/button_server.py:1:1: E266 Too many leading `#` before block comment
+ examples/reference/models/button_server.py:1:1: E266 [*] Too many leading `#` before block comment
- examples/reference/models/checkbox_button_server.py:1:1: E266 Too many leading `#` before block comment
+ examples/reference/models/checkbox_button_server.py:1:1: E266 [*] Too many leading `#` before block comment
- examples/reference/models/checkbox_button_server.py:24:44: E262 Inline comment should start with `# `
+ examples/reference/models/checkbox_button_server.py:24:44: E262 [*] Inline comment should start with `# `
- examples/reference/models/checkbox_button_server.py:26:5: E266 Too many leading `#` before block comment
+ examples/reference/models/checkbox_button_server.py:26:5: E266 [*] Too many leading `#` before block comment
- examples/reference/models/checkbox_button_server.py:33:5: E266 Too many leading `#` before block comment
+ examples/reference/models/checkbox_button_server.py:33:5: E266 [*] Too many leading `#` before block comment
- examples/reference/models/checkbox_server.py:1:1: E266 Too many leading `#` before block comment
+ examples/reference/models/checkbox_server.py:1:1: E266 [*] Too many leading `#` before block comment
- examples/reference/models/checkbox_server.py:21:37: E262 Inline comment should start with `# `
+ examples/reference/models/checkbox_server.py:21:37: E262 [*] Inline comment should start with `# `
- examples/reference/models/checkbox_server.py:23:5: E266 Too many leading `#` before block comment
+ examples/reference/models/checkbox_server.py:23:5: E266 [*] Too many leading `#` before block comment
- examples/reference/models/checkbox_server.py:30:5: E266 Too many leading `#` before block comment
+ examples/reference/models/checkbox_server.py:30:5: E266 [*] Too many leading `#` before block comment
- examples/reference/models/data_table_server.py:1:1: E266 Too many leading `#` before block comment
+ examples/reference/models/data_table_server.py:1:1: E266 [*] Too many leading `#` before block comment
... 55 additional changes omitted for rule E266
- examples/reference/models/dropdown_menu_server.py:22:36: E262 Inline comment should start with `# `
+ examples/reference/models/dropdown_menu_server.py:22:36: E262 [*] Inline comment should start with `# `
- examples/reference/models/multi_select_server.py:13:46: E262 Inline comment should start with `# `
+ examples/reference/models/multi_select_server.py:13:46: E262 [*] Inline comment should start with `# `
- examples/reference/models/multi_select_server.py:26:39: E262 Inline comment should start with `# `
... 19051 additional changes omitted for project

commaai/openpilot (+0 -0 violations, +110 -0 fixes)

ruff check --no-cache --exit-zero --preview

- common/logging_extra.py:184:5: E265 Block comment should start with `# `
+ common/logging_extra.py:184:5: E265 [*] Block comment should start with `# `
- common/logging_extra.py:185:5: E265 Block comment should start with `# `
+ common/logging_extra.py:185:5: E265 [*] Block comment should start with `# `
- common/transformations/camera.py:5:1: E266 Too many leading `#` before block comment
+ common/transformations/camera.py:5:1: E266 [*] Too many leading `#` before block comment
- common/transformations/tests/test_orientation.py:63:7: E265 Block comment should start with `# `
+ common/transformations/tests/test_orientation.py:63:7: E265 [*] Block comment should start with `# `
... 87 additional changes omitted for rule E265
- selfdrive/car/ford/carcontroller.py:47:5: E266 Too many leading `#` before block comment
+ selfdrive/car/ford/carcontroller.py:47:5: E266 [*] Too many leading `#` before block comment
... 100 additional changes omitted for project

fronzbot/blinkpy (+0 -0 violations, +8 -0 fixes)

ruff check --no-cache --exit-zero --preview

- blinksync/forms.py:112:5: E265 Block comment should start with `# `
+ blinksync/forms.py:112:5: E265 [*] Block comment should start with `# `
- blinksync/forms.py:16:9: E265 Block comment should start with `# `
+ blinksync/forms.py:16:9: E265 [*] Block comment should start with `# `
- blinksync/forms.py:55:5: E265 Block comment should start with `# `
+ blinksync/forms.py:55:5: E265 [*] Block comment should start with `# `
- blinksync/forms.py:81:5: E265 Block comment should start with `# `
+ blinksync/forms.py:81:5: E265 [*] Block comment should start with `# `

... Truncated remaining completed projected reports due to GitHub comment length restrictions

Changes by rule (3 rules affected)

code	total	- violation	+ fix
E265	19106	0	19106
E266	1068	0	1068
E262	45	1	44

Add fix for comment-related whitespace rules

fe2ef2c

charliermarsh added fixes Related to suggested fixes for violations preview Related to preview mode features labels Dec 9, 2023

charliermarsh merged commit cb8a2f5 into main Dec 9, 2023

charliermarsh deleted the charlie/E26 branch December 9, 2023 20:18

krehel mentioned this pull request Dec 13, 2023

ruff 0.1.8 Homebrew/homebrew-core#157266

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add fix for comment-related whitespace rules#9075

Add fix for comment-related whitespace rules#9075
charliermarsh merged 1 commit intomainfrom
charlie/E26

charliermarsh commented Dec 9, 2023

Uh oh!

github-actions bot commented Dec 9, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

charliermarsh commented Dec 9, 2023

Uh oh!

github-actions bot commented Dec 9, 2023

ruff-ecosystem results

Linter (stable)

Linter (preview)

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

`ruff-ecosystem` results