Avoid ANN2xx autofix for abstract methods with empty body#9034
Merged
dhruvmanila merged 1 commit intomainfrom Dec 7, 2023
Merged
Avoid ANN2xx autofix for abstract methods with empty body#9034dhruvmanila merged 1 commit intomainfrom
ANN2xx autofix for abstract methods with empty body#9034dhruvmanila merged 1 commit intomainfrom
Conversation
Member
Author
|
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
Member
Author
|
(I hope I understood the issue correctly 😅) |
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the
ANN201,ANN202,ANN205, andANN206rules to not create a fix for the return type when it's an abstract method and the function body is empty i.e., it only contains either a pass statement, docstring or an ellipsis literal.fixes: #9004
Test Plan
Add the following test cases: