Skip to content

[flake8-pyi] Check for kwarg and vararg NoReturn type annotations#8948

Merged
charliermarsh merged 2 commits intoastral-sh:mainfrom
tjkuson:noreturn-false-negative
Dec 1, 2023
Merged

[flake8-pyi] Check for kwarg and vararg NoReturn type annotations#8948
charliermarsh merged 2 commits intoastral-sh:mainfrom
tjkuson:noreturn-false-negative

Conversation

@tjkuson
Copy link
Copy Markdown
Contributor

@tjkuson tjkuson commented Dec 1, 2023

Summary

Triggers no-return-argument-annotation-in-stub (PYI050) for vararg and kwarg NoReturn type annotations.

Related to #8771.

Test Plan

cargo test

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 1, 2023

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@tjkuson tjkuson marked this pull request as ready for review December 1, 2023 16:43
Copy link
Copy Markdown
Member

@charliermarsh charliermarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@charliermarsh charliermarsh added the rule Implementing or modifying a lint rule label Dec 1, 2023
@charliermarsh charliermarsh changed the title Check for kwarg and vararg NoReturn type annotations [flake8-pyi] Check for kwarg and vararg NoReturn type annotations Dec 1, 2023
@charliermarsh charliermarsh merged commit d66063b into astral-sh:main Dec 1, 2023
@tjkuson tjkuson deleted the noreturn-false-negative branch December 1, 2023 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rule Implementing or modifying a lint rule

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants