Inline trailing comments for type alias similar to assignments#8941
Merged
MichaReiser merged 1 commit intomainfrom Dec 4, 2023
Merged
Inline trailing comments for type alias similar to assignments#8941MichaReiser merged 1 commit intomainfrom
MichaReiser merged 1 commit intomainfrom
Conversation
Member
Author
|
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
charliermarsh
approved these changes
Dec 1, 2023
Member
charliermarsh
left a comment
There was a problem hiding this comment.
I think this is correct.
Contributor
|
76110f7 to
1de4fcd
Compare
25a55eb to
7d948b2
Compare
This was referenced Dec 1, 2023
Base automatically changed from
refactor-last-statement-expression-comment-formatting
to
main
December 4, 2023 05:12
7d948b2 to
8fbb3c8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR aligns the comment formatting for type aliases with the assignment formatting.
Black and Ruff inline a trailing assignment comment into the parentheses of the value if the value gets parenthesized.
Neither Black or Ruff apply this layout for type assignments today. To me, this feels inconsistent because type alias statements are just a specific form of assignment.
Note that this is a Black divergence. Depending on the ecosystem check results, we should consider hiding this behind preview for now. Although I don't expect this to be common, considering that type aliases are new.
Test Plan
Added tests.
The similarity index remain unchanged.