Skip to content

Enable auto-return-type involving Optional and Union annotations#8885

Merged
charliermarsh merged 1 commit intomainfrom
charlie/union
Nov 29, 2023
Merged

Enable auto-return-type involving Optional and Union annotations#8885
charliermarsh merged 1 commit intomainfrom
charlie/union

Conversation

@charliermarsh
Copy link
Copy Markdown
Member

@charliermarsh charliermarsh commented Nov 28, 2023

Summary

Previously, this was only supported for Python 3.10 and later, since we always use the PEP 604-style unions.

@charliermarsh charliermarsh added the rule Implementing or modifying a lint rule label Nov 29, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 29, 2023

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Formatter (stable)

✅ ecosystem check detected no format changes.

Formatter (preview)

✅ ecosystem check detected no format changes.

dhruvmanila
dhruvmanila approved these changes Nov 29, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@dhruvmanila dhruvmanila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is pretty cool!

@charliermarsh charliermarsh merged commit 6435e4e into main Nov 29, 2023
@charliermarsh charliermarsh deleted the charlie/union branch November 29, 2023 02:35
@miccal miccal mentioned this pull request Dec 5, 2023
Merged
@dylwil3 dylwil3 mentioned this pull request Feb 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dhruvmanila dhruvmanila dhruvmanila approved these changes

Assignees

No one assigned

Labels

rule Implementing or modifying a lint rule

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@charliermarsh @dhruvmanila