[refurb] Implement redundant-log-base (FURB163)#8842
[refurb] Implement redundant-log-base (FURB163)#8842charliermarsh merged 6 commits intoastral-sh:mainfrom
refurb] Implement redundant-log-base (FURB163)#8842Conversation
|
zanieb
left a comment
There was a problem hiding this comment.
Nice! This lgtm except the rule needs to go through preview.
Co-authored-by: Zanie Blue <contact@zanie.dev>
|
IMO the term "redundant" is not quite right (except the |
|
Yeah, that's fair. I did think about which name to use when porting the rule, but never found one I fully liked (it has to both describe both the I also tried to make the rule message be explicit with what its recommendation is, to guard against confusion. Happy for name to changed, though. I'm not a huge fan of it. Also, for what it's worth, the corresponding refurb rule EDIT: Maybe EDIT 2: 'Accuracy', not 'precision', is the correct term to use here. |
|
I think the name is fine. You could use |
|
Got it on the name. So my only nit is: in the rule description, replace "precise" with "accurate"; both |
crates/ruff_linter/src/rules/refurb/rules/redundant_log_base.rs
Outdated
Show resolved
Hide resolved
3e64f5d to
7a726c6
Compare
7a726c6 to
2144a6a
Compare
Summary
Implement
simplify-math-logasredundant-log-base(FURB163).Auto-fixes
to
Related to #1348.
Test Plan
cargo test