Skip to content

[PIE796] don't report when using ellipses for enum values in stub files#8825

Merged
charliermarsh merged 2 commits intoastral-sh:mainfrom
sciyoshi:pie796-stub-ellipsis
Nov 24, 2023
Merged

[PIE796] don't report when using ellipses for enum values in stub files#8825
charliermarsh merged 2 commits intoastral-sh:mainfrom
sciyoshi:pie796-stub-ellipsis

Conversation

@sciyoshi
Copy link
Copy Markdown
Contributor

@sciyoshi sciyoshi commented Nov 23, 2023

Summary

Just ignores ellipses as enum values inside stub files.

Fixes #8818.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 23, 2023

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Formatter (stable)

✅ ecosystem check detected no format changes.

Formatter (preview)

✅ ecosystem check detected no format changes.

@charliermarsh
Copy link
Copy Markdown
Member

charliermarsh commented Nov 24, 2023

Thanks!

@charliermarsh charliermarsh merged commit 852a8f4 into astral-sh:main Nov 24, 2023
@sciyoshi sciyoshi deleted the pie796-stub-ellipsis branch November 24, 2023 15:29
@miccal miccal mentioned this pull request Dec 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@konstin konstin konstin approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

False positive in PYI files with ellipsis for PIE796

3 participants

@sciyoshi @charliermarsh @konstin