Skip to content

Avoid D100 for Jupyter Notebooks#8816

Merged
dhruvmanila merged 2 commits intomainfrom
dhruv/notebook-d100
Nov 22, 2023
Merged

Avoid D100 for Jupyter Notebooks#8816
dhruvmanila merged 2 commits intomainfrom
dhruv/notebook-d100

Conversation

@dhruvmanila
Copy link
Copy Markdown
Member

This PR avoids triggering D100 for Jupyter Notebooks.

Part of #8669

@dhruvmanila
Copy link
Copy Markdown
Member Author

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@dhruvmanila dhruvmanila added the rule Implementing or modifying a lint rule label Nov 21, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 21, 2023

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Copy link
Copy Markdown
Member

@charliermarsh charliermarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a test for this? I think I added a Jupyter test in the past, if you grep for F821_22.ipynb.

@dhruvmanila dhruvmanila enabled auto-merge (squash) November 22, 2023 15:21
@dhruvmanila dhruvmanila merged commit 0cb438d into main Nov 22, 2023
@dhruvmanila dhruvmanila deleted the dhruv/notebook-d100 branch November 22, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rule Implementing or modifying a lint rule

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants