Extend unnecessary-pass (PIE790) to include ellipses in preview#8641
Merged
charliermarsh merged 3 commits intomainfrom Nov 13, 2023
Merged
Extend unnecessary-pass (PIE790) to include ellipses in preview#8641charliermarsh merged 3 commits intomainfrom
unnecessary-pass (PIE790) to include ellipses in preview#8641charliermarsh merged 3 commits intomainfrom
Conversation
Contributor
|
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| PIE790 | 29 | 29 | 0 | 0 | 0 |
dhruvmanila
approved these changes
Nov 13, 2023
crates/ruff_linter/src/rules/flake8_pie/rules/unnecessary_placeholder.rs
Outdated
Show resolved
Hide resolved
crates/ruff_linter/src/rules/flake8_pie/rules/unnecessary_placeholder.rs
Show resolved
Hide resolved
...s/flake8_pie/snapshots/ruff_linter__rules__flake8_pie__tests__preview__PIE790_PIE790.py.snap
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR extends
unnecessary-pass(PIE790) to flag unnecessary ellipsis expressions in addition topassstatements. Apassis equivalent to a standalone..., so it feels correct to me that a single rule should cover both cases.When we look to v0.2.0, we should also consider deprecating
PYI013, which flags ellipses only for classes.Closes #8602.