Avoid raising TRIO115 violations for trio.sleep(...) calls with non-number values#8532
Merged
zanieb merged 2 commits intoastral-sh:mainfrom Nov 6, 2023
Merged
Avoid raising TRIO115 violations for trio.sleep(...) calls with non-number values#8532zanieb merged 2 commits intoastral-sh:mainfrom
TRIO115 violations for trio.sleep(...) calls with non-number values#8532zanieb merged 2 commits intoastral-sh:mainfrom
Conversation
TRIO115] Return if assigned value of arg is not an Expr::NumberLiteral in TRIO115TRIO115 violations for trio.sleep(...) calls with non-number values
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes bug in
TRIO115where it would notreturnfor values that were not aNumberLiteralsowould set off a false positive
Test Plan
Added test case to fixture