[TRIO] Add TRIO105: SyncTrioCall#8490
Merged
charliermarsh merged 4 commits intoastral-sh:mainfrom Nov 5, 2023
Merged
Conversation
Contributor
|
charliermarsh
approved these changes
Nov 5, 2023
Member
charliermarsh
left a comment
There was a problem hiding this comment.
LGTM! Pulled MethodName into a shared file and implementation. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
TRIO105from the flake8-trio plugin. TheMethodNamelogic mirrors that ofTRIO100to stay consistent within the plugin.It is at 95% parity with the exception of upstream also checking for a slightly more complex scenario where a call to
start()on atrio.Nurserycontext should also be immediately awaited. Upstream plugin appears to just check for anything namednurseryjudging from the relevant issue.Unsure if we want to do so something similar or, alternatively, if there is some capability in ruff to check for calls made on this context some other way
Test Plan
Added a new fixture, based on the one from upstream plugin
Issue link
Refers: #8451