Skip to content

Remove trailing periods from NumPy 2.0 code actions#8475

Merged
charliermarsh merged 1 commit intomainfrom
charlie/period
Nov 3, 2023
Merged

Remove trailing periods from NumPy 2.0 code actions#8475
charliermarsh merged 1 commit intomainfrom
charlie/period

Conversation

@charliermarsh
Copy link
Member

@charliermarsh charliermarsh commented Nov 3, 2023

Very minor consistency thing with other rules. For code actions, we tend to say Replace with {X} rathern than Use {X} instead.

@charliermarsh charliermarsh added rule Implementing or modifying a lint rule bug Something isn't working and removed rule Implementing or modifying a lint rule labels Nov 3, 2023
@charliermarsh charliermarsh enabled auto-merge (squash) November 3, 2023 16:17
@charliermarsh charliermarsh merged commit 536ac55 into main Nov 3, 2023
@charliermarsh charliermarsh deleted the charlie/period branch November 3, 2023 16:28
@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2023

ruff-ecosystem results

Linter (stable)

ℹ️ ecosystem check detected linter changes. (+0 -9 violations, +0 -0 fixes in 41 projects)

bokeh/bokeh (+0 -1 violations, +0 -0 fixes) 

ruff check --no-cache --exit-zero --select ALL

- examples/interaction/tools/subcoordinates_zoom.py:22:23: RUF001 String contains ambiguous `µ` (MICRO SIGN). Did you mean `μ` (GREEK SMALL LETTER MU)?

pandas-dev/pandas (+0 -6 violations, +0 -0 fixes) 

- pandas/_libs/tslibs/timedeltas.pyi:58:6: RUF001 String contains ambiguous `µ` (MICRO SIGN). Did you mean `μ` (GREEK SMALL LETTER MU)?
- pandas/core/indexes/base.py:5352:26: RUF003 Comment contains ambiguous `µ` (MICRO SIGN). Did you mean `μ` (GREEK SMALL LETTER MU)?
- pandas/core/indexes/base.py:5353:46: RUF003 Comment contains ambiguous `µ` (MICRO SIGN). Did you mean `μ` (GREEK SMALL LETTER MU)?
- pandas/core/indexes/base.py:5354:69: RUF003 Comment contains ambiguous `µ` (MICRO SIGN). Did you mean `μ` (GREEK SMALL LETTER MU)?
- pandas/tests/io/test_clipboard.py:67:34: RUF001 String contains ambiguous `µ` (MICRO SIGN). Did you mean `μ` (GREEK SMALL LETTER MU)?
- pandas/tests/scalar/timedelta/test_constructors.py:306:25: RUF001 String contains ambiguous `µ` (MICRO SIGN). Did you mean `μ` (GREEK SMALL LETTER MU)?

zulip/zulip (+0 -2 violations, +0 -0 fixes) 

ruff check --no-cache --exit-zero --select ALL

- zerver/tests/test_invite.py:1281:32: RUF001 String contains ambiguous `µ` (MICRO SIGN). Did you mean `μ` (GREEK SMALL LETTER MU)?
- zerver/tests/test_signup.py:1021:29: RUF001 String contains ambiguous `µ` (MICRO SIGN). Did you mean `μ` (GREEK SMALL LETTER MU)?

Changes by rule (2 rules affected)

code total + violation - violation + fix - fix
RUF001 6 0 6 0 0
RUF003 3 0 3 0 0

Linter (preview)

✅ ecosystem check detected no linter changes.

@miccal miccal mentioned this pull request Nov 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@charliermarsh