Skip to content

Remove unicode flag from comparable#8440

Merged
dhruvmanila merged 1 commit intomainfrom
dhruv/comparable
Nov 2, 2023
Merged

Remove unicode flag from comparable#8440
dhruvmanila merged 1 commit intomainfrom
dhruv/comparable

Conversation

@dhruvmanila
Copy link
Member

@dhruvmanila dhruvmanila commented Nov 2, 2023

Summary

This PR removes the unicode flag from the string literal in ComparableExpr. This flag isn't required as all strings are unicode in Python 3 so "foo" == u"foo".

@dhruvmanila dhruvmanila added the internal An internal refactor or improvement label Nov 2, 2023
@MichaReiser
Copy link
Member

MichaReiser commented Nov 2, 2023

Let's hear ecosytem's opinion on that

@github-actions
Copy link
Contributor

github-actions bot commented Nov 2, 2023

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

ℹ️ ecosystem check detected linter changes. (+0 -18 violations, +0 -0 fixes in 41 projects)

pandas-dev/pandas (+0 -18 violations, +0 -0 fixes) 

ruff check --no-cache --exit-zero --preview

- pandas/core/reshape/merge.py:1196:24: PLR6201 Use a `set` literal when testing for membership
- pandas/core/reshape/merge.py:1611:24: PLR6201 Use a `set` literal when testing for membership
- pandas/core/reshape/merge.py:1626:26: PLR6201 Use a `set` literal when testing for membership
- pandas/core/reshape/merge.py:1632:26: PLR6201 Use a `set` literal when testing for membership
- pandas/core/reshape/merge.py:1639:26: PLR6201 Use a `set` literal when testing for membership
- pandas/core/reshape/merge.py:1687:19: PLR6201 Use a `set` literal when testing for membership
- pandas/core/reshape/merge.py:1689:34: PLR6201 Use a `set` literal when testing for membership
- pandas/core/reshape/merge.py:1692:19: PLR6201 Use a `set` literal when testing for membership
- pandas/core/reshape/merge.py:1694:34: PLR6201 Use a `set` literal when testing for membership
- pandas/core/reshape/merge.py:1718:15: PLR6201 Use a `set` literal when testing for membership
- pandas/core/reshape/merge.py:1912:34: PLR6201 Use a `set` literal when testing for membership
- pandas/core/reshape/merge.py:2093:9: PLR6301 Method `_convert_values_for_libjoin` could be a function, class method, or static method
- pandas/core/reshape/merge.py:2394:37: PLR6201 Use a `set` literal when testing for membership
- pandas/core/reshape/merge.py:2396:13: PLC0415 `import` should be at the top-level of a file
- pandas/core/reshape/merge.py:2397:13: PLC0415 `import` should be at the top-level of a file
- pandas/core/reshape/merge.py:293:5: PLC0415 `import` should be at the top-level of a file
- pandas/core/reshape/merge.py:426:62: PLW0108 Lambda may be unnecessary; consider inlining inner function
- pandas/core/reshape/merge.py:876:9: PLC0415 `import` should be at the top-level of a file

Changes by rule (4 rules affected)

code total + violation - violation + fix - fix
PLR6201 12 0 12 0 0
PLC0415 4 0 4 0 0
PLR6301 1 0 1 0 0
PLW0108 1 0 1 0 0

Formatter (stable)

✅ ecosystem check detected no format changes.

Formatter (preview)

✅ ecosystem check detected no format changes.

@dhruvmanila
Copy link
Member Author

dhruvmanila commented Nov 2, 2023

The results doesn't seem related but let me rebase.

@dhruvmanila
Copy link
Member Author

dhruvmanila commented Nov 2, 2023

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 2, 2023

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Formatter (stable)

✅ ecosystem check detected no format changes.

Formatter (preview)

✅ ecosystem check detected no format changes.

@dhruvmanila dhruvmanila merged commit d350ede into main Nov 2, 2023
@dhruvmanila dhruvmanila deleted the dhruv/comparable branch November 2, 2023 07:51
@dhruvmanila
Copy link
Member Author

dhruvmanila commented Nov 2, 2023

\cc @zanieb Shouldn't the ecosystem check update the existing comment?

@miccal miccal mentioned this pull request Nov 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MichaReiser MichaReiser MichaReiser approved these changes

@charliermarsh charliermarsh Awaiting requested review from charliermarsh

Assignees

No one assigned

Labels

internal An internal refactor or improvement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dhruvmanila @MichaReiser