Merged
Conversation
Contributor
|
Contributor
|
Member
charliermarsh
left a comment
There was a problem hiding this comment.
Looks great! Just some small comments.
crates/ruff_linter/src/rules/flake8_trio/rules/timeout_without_await.rs
Outdated
Show resolved
Hide resolved
crates/ruff_linter/src/rules/flake8_trio/rules/timeout_without_await.rs
Outdated
Show resolved
Hide resolved
273ae27 to
6739414
Compare
Member
|
Thanks! I also created #8451 to track flake8-trio. |
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request adds flake8-trio support to ruff, which is a very useful plugin for trio users to avoid very common mistakes.
Part of #8451.
Test Plan
Traditional rule testing, as described in the documentation.