Merged
Conversation
dhruvmanila
commented
Oct 26, 2023
Comment on lines
-157
to
+162
| _ => bail!("cannot diff Python source code with Jupyter notebook source code"), | ||
| _ => panic!("cannot diff Python source code with Jupyter notebook source code"), |
Member
Author
There was a problem hiding this comment.
We could potentially create a new SourceError::IncompatibleDiffSource variant but then the Diagnostics:from_source_error needs to be updated which I don't think is correct because the diff error shouldn't really be a diagnostic.
Member
There was a problem hiding this comment.
I really wish we had a way to enforce this statically through types (i.e., that this path should never be reached).
Contributor
PR Check ResultsEcosystemℹ️ ecosystem check detected changes. (+0, -0, 1 error(s)) build (error)https://github.com/pypa/build ref main select ignore exclude
|
charliermarsh
approved these changes
Oct 26, 2023
MichaReiser
approved these changes
Oct 26, 2023
Member
|
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors the formatter diff code to reuse the
SourceKind::difflogic. This has the benefit that the Notebook diff now includes the cell numbers which was not present before.Test Plan
Update the snapshots and verified the cell numbers.