Skip to content

Add autofix for PYI030#7934

Merged
zanieb merged 6 commits intoastral-sh:mainfrom
diceroll123:tweak-PYI030
Nov 30, 2023
Merged

Add autofix for PYI030#7934
zanieb merged 6 commits intoastral-sh:mainfrom
diceroll123:tweak-PYI030

Conversation

@diceroll123
Copy link
Copy Markdown
Contributor

@diceroll123 diceroll123 commented Oct 13, 2023 •
edited
Loading

Summary

Part 2 of implementing the reverted autofix for PYI030

Also handles typing.Union and typing_extensions.Literal etc, uses the first subscript name it finds for each offensive line.

Test Plan

cargo test and manually

@zanieb zanieb mentioned this pull request Oct 13, 2023
Merged
zanieb added a commit that referenced this pull request Oct 13, 2023
@zanieb
Revert "add autofix for PYI030" (#7943)
8255e4e 
This reverts commit #7880 (d8c0360)
which does not perform the correct fix per
#7934
@diceroll123 diceroll123 marked this pull request as ready for review October 14, 2023 23:24
@diceroll123 diceroll123 changed the title Fix PYI030 bug with non-literal unions Add autofix for PYI030 Oct 14, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 14, 2023 •
edited
Loading

PR Check Results

Ecosystem

✅ ecosystem check detected no changes.

@diceroll123 diceroll123 mentioned this pull request Oct 14, 2023
Closed
@zanieb
Copy link
Copy Markdown
Member

zanieb commented Oct 15, 2023

Could you gate this fix so it only applies when preview mode is enabled?

@diceroll123
Copy link
Copy Markdown
Contributor Author

diceroll123 commented Oct 15, 2023

I believe I've done this correctly, doesn't seem like any other fix is gated this way. 🤔 If I've done this wrong, please advise!

@zanieb zanieb self-requested a review October 16, 2023 21:28
@zanieb zanieb self-assigned this Oct 17, 2023
@zanieb zanieb mentioned this pull request Oct 19, 2023
Open
@zanieb
Copy link
Copy Markdown
Member

zanieb commented Oct 28, 2023

Hey sorry this is on my todo list to review but I got distracted last week – I'll try to get to this on Monday!

@diceroll123
Copy link
Copy Markdown
Contributor Author

diceroll123 commented Oct 28, 2023

Hey sorry this is on my todo list to review but I got distracted last week – I'll try to get to this on Monday!

Take your time!

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 24, 2023 •
edited
Loading

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

ℹ️ ecosystem check detected linter changes. (+0 -0 violations, +6 -0 fixes in 41 projects)

apache/airflow (+0 -0 violations, +6 -0 fixes) 

ruff check --no-cache --exit-zero --preview --select ALL

- airflow/cli/commands/task_command.py:80:21: PYI030 Multiple literal members in a union. Use a single literal, e.g. `Literal[False, "db", "memory"]`
+ airflow/cli/commands/task_command.py:80:21: PYI030 [*] Multiple literal members in a union. Use a single literal, e.g. `Literal[False, "db", "memory"]`
- airflow/models/mappedoperator.py:88:20: PYI030 Multiple literal members in a union. Use a single literal, e.g. `Literal["expand", "partial"]`
+ airflow/models/mappedoperator.py:88:20: PYI030 [*] Multiple literal members in a union. Use a single literal, e.g. `Literal["expand", "partial"]`
- airflow/providers_manager.py:195:24: PYI030 Multiple literal members in a union. Use a single literal, e.g. `Literal["source", "package"]`
+ airflow/providers_manager.py:195:24: PYI030 [*] Multiple literal members in a union. Use a single literal, e.g. `Literal["source", "package"]`

Changes by rule (1 rules affected)

code total + violation - violation + fix - fix
PYI030 6 0 0 6 0

zanieb
zanieb approved these changes Nov 30, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@zanieb zanieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This lgtm! Thanks for your patience.

@zanieb zanieb enabled auto-merge (squash) November 30, 2023 22:11
@zanieb zanieb merged commit bbad4b4 into astral-sh:main Nov 30, 2023
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Nov 30, 2023

CodSpeed Performance Report

Merging #7934 will improve performances by 12.27%

Comparing diceroll123:tweak-PYI030 (2f6dd84) with main (2590aa3)

Summary

⚡ 5 improvements
✅ 20 untouched benchmarks

🆕 5 new benchmarks

Benchmarks breakdown

Benchmark main diceroll123:tweak-PYI030 Change
⚡ linter/all-rules[pydantic/types.py] 80.5 ms 72.1 ms +11.63%
⚡ linter/all-rules[unicode/pypinyin.py] 17.2 ms 16.2 ms +6.12%
🆕 linter/all-with-preview-rules[unicode/pypinyin.py] N/A 17.2 ms N/A
⚡ linter/all-rules[numpy/ctypeslib.py] 37 ms 34.2 ms +8.23%
🆕 linter/all-with-preview-rules[pydantic/types.py] N/A 78.8 ms N/A
⚡ linter/all-rules[large/dataset.py] 185.7 ms 165.4 ms +12.27%
🆕 linter/all-with-preview-rules[large/dataset.py] N/A 185.8 ms N/A
⚡ linter/all-rules[numpy/globals.py] 4.1 ms 3.9 ms +5.9%
🆕 linter/all-with-preview-rules[numpy/ctypeslib.py] N/A 37.3 ms N/A
🆕 linter/all-with-preview-rules[numpy/globals.py] N/A 4.2 ms N/A

@zanieb zanieb added rule Implementing or modifying a lint rule preview Related to preview mode features labels Nov 30, 2023
@miccal miccal mentioned this pull request Dec 5, 2023
Merged
@zanieb zanieb mentioned this pull request Dec 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zanieb zanieb zanieb approved these changes

Assignees

@zanieb zanieb

Labels

preview Related to preview mode features rule Implementing or modifying a lint rule

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@diceroll123 @zanieb