[SIM115] Allow open followed by close#7916
Merged
charliermarsh merged 4 commits intoastral-sh:mainfrom Oct 11, 2023
Merged
Conversation
Contributor
PR Check ResultsEcosystemℹ️ ecosystem check detected changes. (+0, -9, 0 error(s)) airflow (+0, -9)
- airflow/utils/log/file_processor_handler.py:150:13: SIM115 Use context handler for opening files - airflow/utils/log/file_task_handler.py:482:13: SIM115 Use context handler for opening files - tests/core/test_logging_config.py:146:17: SIM115 Use context handler for opening files - tests/core/test_logging_config.py:148:13: SIM115 Use context handler for opening files - tests/providers/apache/beam/operators/test_beam.py:433:13: SIM115 Use context handler for opening files - tests/providers/apache/beam/operators/test_beam.py:598:13: SIM115 Use context handler for opening files - tests/sensors/test_filesystem.py:103:13: SIM115 Use context handler for opening files - tests/sensors/test_filesystem.py:162:17: SIM115 Use context handler for opening files - tests/sensors/test_filesystem.py:181:13: SIM115 Use context handler for opening files
|
konstin
approved these changes
Oct 11, 2023
| f = exit_stack_.enter_context(open("filename")) | ||
|
|
||
| # OK | ||
| open("filename").close() |
Member
There was a problem hiding this comment.
Could you add a comment why this combination is needed?
Contributor
Author
There was a problem hiding this comment.
Suggested change
| open("filename").close() | |
| # OK (file is closed immdeidately) | |
| open("filename").close() |
comment like this?
Member
There was a problem hiding this comment.
More like "Used to clear an existing file (https://stackoverflow.com/a/2769090/3549270)"
There's Path.touch now but i'm surprised there's nothing similar from clearing a file.
Member
|
For append instead of write cases, e.g. https://github.com/apache/airflow/blob/e239dcf644b6e68896923d84dd49e9cbb6271373/airflow/utils/log/file_processor_handler.py#L150, i'd recommend using |
harupy
commented
Oct 11, 2023
crates/ruff_linter/resources/test/fixtures/flake8_simplify/SIM115.py
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#7907
Test Plan
New test cases