[refurb] Implement read-whole-file [FURB101]#7682
Merged
charliermarsh merged 4 commits intoastral-sh:mainfrom Oct 20, 2023
Merged
[refurb] Implement read-whole-file [FURB101]#7682charliermarsh merged 4 commits intoastral-sh:mainfrom
read-whole-file [FURB101]#7682charliermarsh merged 4 commits intoastral-sh:mainfrom
Conversation
8f08ccd to
f848029
Compare
CodSpeed Performance ReportMerging #7682 will not alter performanceComparing Summary
|
Contributor
PR Check ResultsEcosystem✅ ecosystem check detected no changes. |
Contributor
Author
|
Hey @charliermarsh 👋 Do you mind taking a look at this PR? Thanks! 🙏 |
Member
|
Sorry, this is absolutely on my list, it's just a big rule implementation so trying to find time to focus on it. |
Contributor
Author
|
@charliermarsh a gentle ping |
Member
|
@SavchenkoValeriy - Sorry for the delay, reading now! |
charliermarsh
approved these changes
Oct 20, 2023
Contributor
Author
|
Oh, really nice catch with argument unpacking! ❤️ |
Member
|
@SavchenkoValeriy - I think there are a few cases we could catch, but it felt like it didn't merit the complexity budget. |
Member
|
Excellent work @SavchenkoValeriy |
dhruvmanila
added a commit
that referenced
this pull request
Apr 11, 2024
Glyphack
pushed a commit
to Glyphack/ruff
that referenced
this pull request
Apr 12, 2024
## Summary Implement `write-whole-file` (`FURB103`), part of astral-sh#1348. This is largely a copy and paste of `read-whole-file` astral-sh#7682. ## Test Plan Text fixture added. --------- Co-authored-by: Dhruv Manilawala <dhruvmanila@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR is part of a bigger effort of re-implementing
refurbrules #1348. It adds support for FURB101Test Plan
I included a new test + checked that all other tests pass.