[pylint] Add fix for subprocess-run-without-check (PLW1510)#6708
Merged
charliermarsh merged 10 commits intoastral-sh:mainfrom Dec 12, 2023
Merged
[pylint] Add fix for subprocess-run-without-check (PLW1510)#6708charliermarsh merged 10 commits intoastral-sh:mainfrom
pylint] Add fix for subprocess-run-without-check (PLW1510)#6708charliermarsh merged 10 commits intoastral-sh:mainfrom
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
eaa6274 to
5c86751
Compare
5c86751 to
b41dd36
Compare
crates/ruff/src/rules/pylint/rules/subprocess_run_without_check.rs
Outdated
Show resolved
Hide resolved
crates/ruff/src/rules/pylint/rules/subprocess_run_without_check.rs
Outdated
Show resolved
Hide resolved
Contributor
|
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| PLW1510 | 74 | 0 | 0 | 74 | 0 |
Linter (preview)
ℹ️ ecosystem check detected linter changes. (+0 -0 violations, +74 -0 fixes in 41 projects)
apache/airflow (+0 -0 violations, +22 -0 fixes)
ruff check --no-cache --exit-zero --preview --select ALL
+ airflow/providers/google/cloud/hooks/dataflow.py:1033:20: PLW1510 [*] `subprocess.run` without explicit `check` argument - airflow/providers/google/cloud/hooks/dataflow.py:1033:20: PLW1510 `subprocess.run` without explicit `check` argument + dev/breeze/src/airflow_breeze/utils/publish_docs_builder.py:163:30: PLW1510 [*] `subprocess.run` without explicit `check` argument - dev/breeze/src/airflow_breeze/utils/publish_docs_builder.py:163:30: PLW1510 `subprocess.run` without explicit `check` argument + dev/breeze/src/airflow_breeze/utils/publish_docs_builder.py:242:30: PLW1510 [*] `subprocess.run` without explicit `check` argument - dev/breeze/src/airflow_breeze/utils/publish_docs_builder.py:242:30: PLW1510 `subprocess.run` without explicit `check` argument + docs/exts/docs_build/docs_builder.py:164:30: PLW1510 [*] `subprocess.run` without explicit `check` argument - docs/exts/docs_build/docs_builder.py:164:30: PLW1510 `subprocess.run` without explicit `check` argument + docs/exts/docs_build/docs_builder.py:241:30: PLW1510 [*] `subprocess.run` without explicit `check` argument - docs/exts/docs_build/docs_builder.py:241:30: PLW1510 `subprocess.run` without explicit `check` argument + scripts/ci/pre_commit/pre_commit_update_common_sql_api_stubs.py:320:5: PLW1510 [*] `subprocess.run` without explicit `check` argument - scripts/ci/pre_commit/pre_commit_update_common_sql_api_stubs.py:320:5: PLW1510 `subprocess.run` without explicit `check` argument + scripts/in_container/remove_arm_packages.py:47:5: PLW1510 [*] `subprocess.run` without explicit `check` argument - scripts/in_container/remove_arm_packages.py:47:5: PLW1510 `subprocess.run` without explicit `check` argument ... 8 additional changes omitted for project
bokeh/bokeh (+0 -0 violations, +38 -0 fixes)
ruff check --no-cache --exit-zero --preview --select ALL
+ release/system.py:43:18: PLW1510 [*] `subprocess.run` without explicit `check` argument - release/system.py:43:18: PLW1510 `subprocess.run` without explicit `check` argument + scripts/hooks/install.py:5:5: PLW1510 [*] `subprocess.run` without explicit `check` argument - scripts/hooks/install.py:5:5: PLW1510 `subprocess.run` without explicit `check` argument + scripts/hooks/protect_branches.py:10:22: PLW1510 [*] `subprocess.run` without explicit `check` argument - scripts/hooks/protect_branches.py:10:22: PLW1510 `subprocess.run` without explicit `check` argument + scripts/hooks/uninstall.py:5:5: PLW1510 [*] `subprocess.run` without explicit `check` argument - scripts/hooks/uninstall.py:5:5: PLW1510 `subprocess.run` without explicit `check` argument + setup.py:52:16: PLW1510 [*] `subprocess.run` without explicit `check` argument - setup.py:52:16: PLW1510 `subprocess.run` without explicit `check` argument + tests/codebase/test_eslint.py:37:12: PLW1510 [*] `subprocess.run` without explicit `check` argument - tests/codebase/test_eslint.py:37:12: PLW1510 `subprocess.run` without explicit `check` argument + tests/codebase/test_isort.py:58:12: PLW1510 [*] `subprocess.run` without explicit `check` argument - tests/codebase/test_isort.py:58:12: PLW1510 `subprocess.run` without explicit `check` argument + tests/codebase/test_js_license_set.py:50:12: PLW1510 [*] `subprocess.run` without explicit `check` argument - tests/codebase/test_js_license_set.py:50:12: PLW1510 `subprocess.run` without explicit `check` argument + tests/codebase/test_license.py:40:12: PLW1510 [*] `subprocess.run` without explicit `check` argument - tests/codebase/test_license.py:40:12: PLW1510 `subprocess.run` without explicit `check` argument + tests/codebase/test_no_client_server_common.py:48:12: PLW1510 [*] `subprocess.run` without explicit `check` argument - tests/codebase/test_no_client_server_common.py:48:12: PLW1510 `subprocess.run` without explicit `check` argument + tests/codebase/test_no_client_server_common.py:57:12: PLW1510 [*] `subprocess.run` without explicit `check` argument - tests/codebase/test_no_client_server_common.py:57:12: PLW1510 `subprocess.run` without explicit `check` argument + tests/codebase/test_no_ipython_common.py:51:12: PLW1510 [*] `subprocess.run` without explicit `check` argument - tests/codebase/test_no_ipython_common.py:51:12: PLW1510 `subprocess.run` without explicit `check` argument + tests/codebase/test_no_pandas_common.py:53:12: PLW1510 [*] `subprocess.run` without explicit `check` argument ... 13 additional changes omitted for project
freedomofpress/securedrop (+0 -0 violations, +8 -0 fixes)
ruff check --no-cache --exit-zero --preview
+ admin/bootstrap.py:276:19: PLW1510 [*] `subprocess.run` without explicit `check` argument - admin/bootstrap.py:276:19: PLW1510 `subprocess.run` without explicit `check` argument + admin/bootstrap.py:281:25: PLW1510 [*] `subprocess.run` without explicit `check` argument - admin/bootstrap.py:281:25: PLW1510 `subprocess.run` without explicit `check` argument + devops/scripts/verify-mo.py:116:16: PLW1510 [*] `subprocess.run` without explicit `check` argument - devops/scripts/verify-mo.py:116:16: PLW1510 `subprocess.run` without explicit `check` argument + securedrop/debian/ossec-common/var/ossec/checksdconfig.py:35:14: PLW1510 [*] `subprocess.run` without explicit `check` argument - securedrop/debian/ossec-common/var/ossec/checksdconfig.py:35:14: PLW1510 `subprocess.run` without explicit `check` argument
sphinx-doc/sphinx (+0 -0 violations, +6 -0 fixes)
ruff check --no-cache --exit-zero --preview
+ sphinx/__init__.py:43:19: PLW1510 [*] `subprocess.run` without explicit `check` argument - sphinx/__init__.py:43:19: PLW1510 `subprocess.run` without explicit `check` argument + sphinx/testing/fixtures.py:214:13: PLW1510 [*] `subprocess.run` without explicit `check` argument - sphinx/testing/fixtures.py:214:13: PLW1510 `subprocess.run` without explicit `check` argument + tests/test_ext_imgconverter.py:13:13: PLW1510 [*] `subprocess.run` without explicit `check` argument - tests/test_ext_imgconverter.py:13:13: PLW1510 `subprocess.run` without explicit `check` argument
Changes by rule (1 rules affected)
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| PLW1510 | 74 | 0 | 0 | 74 | 0 |
Contributor
|
shouldn't this fix add to preview? |
Member
|
@T-256 -- Yup! The change itself isn't complete yet. |
Contributor
Author
|
Thanks for the ping. Looks like there's an |
pylint] Add fix for subprocess-run-without-check (PLW1510)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let me know if I should care more about whitespace (and would appreciate pointers if so)