[`pylint`] Implement `import-private-name` (`C2701`) by tjkuson · Pull Request #5920 · astral-sh/ruff

tjkuson · 2023-07-20T13:49:11Z

Summary

Implements import-private-name (C2701) as import-private-name (PLC2701). Includes documentation.

Related to #970.

Closes #9138.

PEP 420 namespace package limitation

checker.module_path doesn't seem to support automatic detection of namespace packages (PEP 420). This leads to 'false' positives (Pylint allows both).

Currently, for this to work like Pylint, users would have to manually input known namespace packages.

Test Plan

cargo test

github-actions · 2023-07-20T14:04:09Z

PR Check Results

Ecosystem

✅ ecosystem check detected no changes.

Benchmark

Linux

group                                      main                                   pr
-----                                      ----                                   --
formatter/large/dataset.py                 1.00      8.3±0.23ms     4.9 MB/sec    1.00      8.3±0.04ms     4.9 MB/sec
formatter/numpy/ctypeslib.py               1.00   1598.8±5.51µs    10.4 MB/sec    1.01  1618.3±12.99µs    10.3 MB/sec
formatter/numpy/globals.py                 1.00    171.0±1.75µs    17.3 MB/sec    1.00    171.1±0.30µs    17.2 MB/sec
formatter/pydantic/types.py                1.00      3.5±0.04ms     7.2 MB/sec    1.00      3.5±0.03ms     7.3 MB/sec
linter/all-rules/large/dataset.py          1.01     10.6±0.03ms     3.9 MB/sec    1.00     10.5±0.04ms     3.9 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.00      2.8±0.00ms     5.8 MB/sec    1.00      2.8±0.01ms     5.9 MB/sec
linter/all-rules/numpy/globals.py          1.01    318.7±0.98µs     9.3 MB/sec    1.00    316.4±1.32µs     9.3 MB/sec
linter/all-rules/pydantic/types.py         1.00      4.9±0.01ms     5.3 MB/sec    1.00      4.8±0.04ms     5.3 MB/sec
linter/default-rules/large/dataset.py      1.02      5.4±0.01ms     7.5 MB/sec    1.00      5.3±0.02ms     7.7 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.01   1115.0±3.37µs    14.9 MB/sec    1.00   1101.9±3.31µs    15.1 MB/sec
linter/default-rules/numpy/globals.py      1.00    114.1±0.33µs    25.9 MB/sec    1.00    114.0±0.19µs    25.9 MB/sec
linter/default-rules/pydantic/types.py     1.01      2.4±0.01ms    10.6 MB/sec    1.00      2.4±0.00ms    10.7 MB/sec

Windows

group                                      main                                   pr
-----                                      ----                                   --
formatter/large/dataset.py                 1.00      9.7±0.08ms     4.2 MB/sec    1.00      9.6±0.08ms     4.2 MB/sec
formatter/numpy/ctypeslib.py               1.00  1883.8±33.01µs     8.8 MB/sec    1.00  1879.0±27.07µs     8.9 MB/sec
formatter/numpy/globals.py                 1.00   213.3±11.27µs    13.8 MB/sec    1.00    214.1±8.20µs    13.8 MB/sec
formatter/pydantic/types.py                1.00      4.0±0.05ms     6.3 MB/sec    1.01      4.1±0.05ms     6.3 MB/sec
linter/all-rules/large/dataset.py          1.02     14.4±0.53ms     2.8 MB/sec    1.00     14.1±0.11ms     2.9 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.04      3.8±0.23ms     4.3 MB/sec    1.00      3.7±0.03ms     4.5 MB/sec
linter/all-rules/numpy/globals.py          1.05   467.7±24.58µs     6.3 MB/sec    1.00    444.9±5.85µs     6.6 MB/sec
linter/all-rules/pydantic/types.py         1.03      6.5±0.28ms     3.9 MB/sec    1.00      6.3±0.06ms     4.1 MB/sec
linter/default-rules/large/dataset.py      1.00      7.3±0.44ms     5.6 MB/sec    1.14      8.3±0.05ms     4.9 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.00  1440.0±65.45µs    11.6 MB/sec    1.15  1651.3±12.67µs    10.1 MB/sec
linter/default-rules/numpy/globals.py      1.00    159.1±3.10µs    18.5 MB/sec    1.13    180.5±2.43µs    16.3 MB/sec
linter/default-rules/pydantic/types.py     1.00      3.1±0.09ms     8.3 MB/sec    1.16      3.6±0.04ms     7.2 MB/sec

tjkuson · 2023-07-20T14:44:59Z

Most of the triggers from the ecosystem check seem to be in test suites, which is fine. The others seem to be false positives from not checking if a module is importing something from itself.

tjkuson · 2023-07-20T22:58:31Z

Looking through the ecosystem check, the flagged violations are all

true positives,
issues with PEP 420 (which can be fixed using the namespace-packages setting,
or test suites importing private names for testing reasons (which makes sense).

tjkuson · 2023-07-27T10:47:51Z

Related: #6114.

AiyionPrime · 2023-10-17T09:09:51Z

@tjkuson Is there anything I can do to help moving this forward?
I'd really like to have this checker in ruff.

Or is all that's left to to a rebase and the review of @charliermarsh?

tjkuson · 2023-10-17T09:23:17Z

@tjkuson Is there anything I can do to help moving this forward? I'd really like to have this checker in ruff.

Or is all that's left to to a rebase and the review of @charliermarsh?

Wow, I forgot about this PR! If I recall correctly, this PR was working but required users to specify namespace packages (otherwise, it would false positive). I'm not a maintainer, but perhaps the team are waiting for #6114 to be solved before accepting this merge?

@charliermarsh I don't mind rebasing and tweaking the PR if you are open to it being merged (I have probably improved with Rust over these months).

AiyionPrime · 2023-10-17T10:37:52Z

If wanted I'd be open to test it prior merging.
Obviously I'm not a maintainer either, but to my understanding C2701 is working, but has a known limitation for projects with namespace packages, which are not all projects.

Might a note in the docs regarding this behavior be sufficient?
It feels like #6114 would be a nice addition but is a quite orthogonal feature?
Or are there likely changes necessary in this PR once it is merged?

Anyway, thanks for the fast response, let me know when I can help :)

charliermarsh · 2023-12-12T20:57:55Z

I think we probably do need to support the type annotation thing, since we changed flake8-self to support this: #9036

charliermarsh · 2023-12-12T21:00:23Z

How does this compare to the flake8-self rules?

tjkuson · 2023-12-12T21:08:22Z

I think we probably do need to support the type annotation thing, since we changed flake8-self to support this: #9036

Sure! It should be a simple change if you are still open to the rule being merged.

How does this compare to the flake8-self rules?

private-member-access doesn't check imports. For example,

from foo import _bar

bar = _bar(...)

won't trigger the rule, but would trigger private-import-name.

charliermarsh · 2023-12-12T21:18:12Z

Thanks @tjkuson. I assume they would both trigger on:

from foo import _bar

bar = _bar._baz(...)

And that only flake8-self would trigger on:

from foo import bar

bar = bar._baz(...)

Is that right?

tjkuson · 2023-12-12T21:21:33Z

Yes! Are you thinking of merging them as one rule?

charliermarsh · 2023-12-12T21:22:08Z

@tjkuson - Eventually maybe... For now, I'm okay with them being separate as long as they don't have overlap.

tjkuson · 2023-12-21T17:41:15Z

Rebased to main, everything seems to be working. Checking if an import is used as a type annotation will take longer as I need to make it a deferred rule…

github-actions · 2023-12-21T17:41:48Z

`ruff-ecosystem` results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

ℹ️ ecosystem check detected linter changes. (+473 -1002 violations, +0 -0 fixes in 12 projects; 31 projects unchanged)

DisnakeDev/disnake (+6 -0 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --preview

+ disnake/ext/commands/base_core.py:26:27: PLC2701 Private name import `_generated` from external module `disnake.utils`
+ disnake/ext/commands/base_core.py:26:39: PLC2701 Private name import `_overload_with_permissions` from external module `disnake.utils`
+ disnake/ext/commands/core.py:31:5: PLC2701 Private name import `_generated` from external module `disnake.utils`
+ disnake/ext/commands/core.py:32:5: PLC2701 Private name import `_overload_with_permissions` from external module `disnake.utils`
+ disnake/ext/commands/flags.py:8:27: PLC2701 Private name import `_generated` from external module `disnake.utils`
+ docs/extensions/attributetable.py:13:27: PLC2701 Private name import `_` from external module `sphinx.locale`

apache/airflow (+98 -0 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --preview --select ALL

+ airflow/api/auth/backend/kerberos_auth.py:55:51: PLC2701 Private name import `_request_ctx_stack` from external module `flask`
+ airflow/io/path.py:29:52: PLC2701 Private name import `_CloudAccessor` from external module `upath.implementations.cloud`
+ airflow/metrics/otel_logger.py:30:56: PLC2701 Private name import `_internal` from external module `opentelemetry.sdk.metrics`
+ airflow/metrics/otel_logger.py:30:79: PLC2701 Private name import `_internal` from external module `opentelemetry.sdk.metrics`
+ airflow/providers/google/cloud/hooks/gcs.py:858:49: PLC2701 Private name import `_blobs_page_start` from external module `google.cloud.storage.bucket`
+ airflow/providers/google/cloud/hooks/gcs.py:858:68: PLC2701 Private name import `_item_to_blob` from external module `google.cloud.storage.bucket`
+ airflow/providers/google/common/hooks/base_google.py:42:35: PLC2701 Private name import `_http_client` from external module `google.auth.transport`
+ airflow/providers/google/common/utils/id_token_credentials.py:149:29: PLC2701 Private name import `_cloud_sdk` from external module `google.auth`
+ airflow/providers/google/common/utils/id_token_credentials.py:175:48: PLC2701 Private name import `_metadata` from external module `google.auth.compute_engine`
+ airflow/providers/google/common/utils/id_token_credentials.py:178:39: PLC2701 Private name import `_http_client` from external module `google.auth.transport`
... 88 additional changes omitted for project

aws/aws-sam-cli (+180 -0 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --preview

+ schema/make_schema.py:12:32: PLC2701 Private name import `_SAM_CLI_COMMAND_PACKAGES` from external module `samcli.cli.command`
+ tests/integration/package/test_package_command_image.py:13:45: PLC2701 Private name import `_utils` from external module `samcli.commands`
+ tests/integration/sync/test_sync_adl.py:5:67: PLC2701 Private name import `_utils` from external module `samcli.commands`
+ tests/unit/commands/_utils/custom_options/test_hook_package_id_option.py:7:68: PLC2701 Private name import `_utils` from external module `samcli.commands`
+ tests/unit/commands/_utils/custom_options/test_hook_package_id_option.py:7:84: PLC2701 Private name import `_utils` from external module `samcli.commands`
+ tests/unit/commands/_utils/custom_options/test_option_nargs.py:4:64: PLC2701 Private name import `_utils` from external module `samcli.commands`
+ tests/unit/commands/_utils/custom_options/test_replace_help_summary_option.py:4:71: PLC2701 Private name import `_utils` from external module `samcli.commands`
+ tests/unit/commands/_utils/test_cdk_support_decorators.py:4:59: PLC2701 Private name import `_utils` from external module `samcli.commands`
+ tests/unit/commands/_utils/test_click_mutex.py:3:48: PLC2701 Private name import `_utils` from external module `samcli.commands`
+ tests/unit/commands/_utils/test_command_exception_handler.py:7:5: PLC2701 Private name import `_utils` from external module `samcli.commands`
... 170 additional changes omitted for project

bokeh/bokeh (+94 -1002 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --preview --select ALL

+ src/bokeh/sphinxext/bokeh_sampledata_xref.py:39:27: PLC2701 Private name import `_` from external module `sphinx.locale`
+ tests/unit/bokeh/command/subcommands/test_json__subcommands.py:29:31: PLC2701 Private name import `_util_subcommands`
+ tests/unit/bokeh/core/property/test_aliases.py:29:28: PLC2701 Private name import `_util_property`
+ tests/unit/bokeh/core/property/test_aliases.py:29:43: PLC2701 Private name import `_util_property`
+ tests/unit/bokeh/core/property/test_any.py:22:28: PLC2701 Private name import `_util_property`
+ tests/unit/bokeh/core/property/test_any.py:22:43: PLC2701 Private name import `_util_property`
... 89 additional changes omitted for rule PLC2701
- tests/unit/bokeh/plotting/test__decorators.py:10:1: E265 [*] Block comment should start with `# `
- tests/unit/bokeh/plotting/test__decorators.py:11:35: E261 [*] Insert at least two spaces before an inline comment
- tests/unit/bokeh/plotting/test__decorators.py:13:14: E203 [*] Whitespace before ';'
- tests/unit/bokeh/plotting/test__decorators.py:13:15: E702 Multiple statements on one line (semicolon)
- tests/unit/bokeh/plotting/test__decorators.py:13:17: B018 Found useless expression. Either assign it to a variable or remove it.
- tests/unit/bokeh/plotting/test__decorators.py:13:1: I001 Import block is un-sorted or un-formatted
- tests/unit/bokeh/plotting/test__decorators.py:15:1: E265 [*] Block comment should start with `# `
- tests/unit/bokeh/plotting/test__decorators.py:17:1: E265 [*] Block comment should start with `# `
- tests/unit/bokeh/plotting/test__decorators.py:1:1: D100 Missing docstring in public module
- tests/unit/bokeh/plotting/test__decorators.py:1:1: E265 [*] Block comment should start with `# `
- tests/unit/bokeh/plotting/test__decorators.py:1:1: INP001 File `tests/unit/bokeh/plotting/test__decorators.py` is part of an implicit namespace package. Add an `__init__.py`.
- tests/unit/bokeh/plotting/test__decorators.py:20:1: E402 Module level import not at top of file
- tests/unit/bokeh/plotting/test__decorators.py:23:1: E402 Module level import not at top of file
- tests/unit/bokeh/plotting/test__decorators.py:24:1: E402 Module level import not at top of file
- tests/unit/bokeh/plotting/test__decorators.py:25:1: E402 Module level import not at top of file
- tests/unit/bokeh/plotting/test__decorators.py:28:1: E402 Module level import not at top of file
- tests/unit/bokeh/plotting/test__decorators.py:28:41: E261 [*] Insert at least two spaces before an inline comment
- tests/unit/bokeh/plotting/test__decorators.py:30:1: E265 [*] Block comment should start with `# `
- tests/unit/bokeh/plotting/test__decorators.py:32:1: E265 [*] Block comment should start with `# `
... 99 additional changes omitted for rule E265
- tests/unit/bokeh/plotting/test__decorators.py:43:3: FIX002 Line contains TODO, consider resolving the issue
- tests/unit/bokeh/plotting/test__decorators.py:43:3: TD002 Missing author in TODO; try: `# TODO(): ...` or `# TODO @: ...`
- tests/unit/bokeh/plotting/test__decorators.py:43:3: TD003 Missing issue link on the line following this TODO
- tests/unit/bokeh/plotting/test__decorators.py:46:25: C408 Unnecessary `dict` call (rewrite as a literal)
- tests/unit/bokeh/plotting/test__decorators.py:56:26: PT006 Wrong name(s) type in `@pytest.mark.parametrize`, expected `tuple`
- tests/unit/bokeh/plotting/test__decorators.py:56:26: Q000 [*] Single quotes found but double quotes preferred
- tests/unit/bokeh/plotting/test__decorators.py:57:39: ANN001 Missing type annotation for function argument `arg`
- tests/unit/bokeh/plotting/test__decorators.py:57:44: ANN001 Missing type annotation for function argument `values`
- tests/unit/bokeh/plotting/test__decorators.py:57:5: D103 Missing docstring in public function
- tests/unit/bokeh/plotting/test__decorators.py:59:25: Q000 [*] Single quotes found but double quotes preferred
- tests/unit/bokeh/plotting/test__decorators.py:60:17: ANN202 Missing return type annotation for private function `foo`
- tests/unit/bokeh/plotting/test__decorators.py:60:23: ANN003 Missing type annotation for `**kw`
... 1059 additional changes omitted for project

freedomofpress/securedrop (+5 -0 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --preview

+ securedrop/secure_tempfile.py:3:22: PLC2701 Private name import `_TemporaryFileWrapper` from external module `tempfile`
+ securedrop/tests/conftest.py:24:25: PLC2701 Private name import `_SourceScryptManager` from external module `source_user`
+ securedrop/tests/test_config.py:3:22: PLC2701 Private name import `_parse_config_from_file` from external module `sdconfig`
+ securedrop/tests/test_source_user.py:11:5: PLC2701 Private name import `_DesignationGenerator` from external module `source_user`
+ securedrop/tests/test_source_user.py:12:5: PLC2701 Private name import `_SourceScryptManager` from external module `source_user`

ibis-project/ibis (+10 -0 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --preview

+ docs/backends/app/backend_info_app.py:14:18: PLC2701 Private name import `_` from external module `ibis`
+ docs/how-to/visualization/example_streamlit_app/example_streamlit_app.py:6:18: PLC2701 Private name import `_` from external module `ibis`
+ docs/posts/pydata-performance-part2/datafusion_ibis.py:4:18: PLC2701 Private name import `_` from external module `ibis`
+ docs/posts/pydata-performance-part2/duckdb_ibis.py:4:18: PLC2701 Private name import `_` from external module `ibis`
+ docs/posts/pydata-performance-part2/polars_ibis.py:4:18: PLC2701 Private name import `_` from external module `ibis`
+ docs/posts/pydata-performance/step0.py:4:18: PLC2701 Private name import `_` from external module `ibis`
+ docs/posts/pydata-performance/step1.py:4:18: PLC2701 Private name import `_` from external module `ibis`
+ docs/posts/pydata-performance/step2.py:4:18: PLC2701 Private name import `_` from external module `ibis`
+ docs/posts/pydata-performance/step3.py:4:18: PLC2701 Private name import `_` from external module `ibis`
+ ibis/backends/conftest.py:11:8: PLC2701 Private name import `_pytest`

... Truncated remaining completed project reports due to GitHub comment length restrictions

Changes by rule (45 rules affected)

code	total	+ violation	- violation
PLC2701	473	473	0
S101	230	0	230
Q000	150	0	150
E265	104	0	104
D102	63	0	63
ANN101	60	0	60
PLR6301	60	0	60
PLR2004	47	0	47
SLF001	38	0	38
E402	23	0	23
C408	22	0	22
E275	18	0	18
PT011	17	0	17
E231	16	0	16
E261	15	0	15
ANN001	15	0	15
ERA001	14	0	14
D101	12	0	12
N801	12	0	12
E203	8	0	8
E702	7	0	7
B018	7	0	7
I001	7	0	7
D100	7	0	7
INP001	7	0	7
D103	6	0	6
A002	6	0	6
E202	4	0	4
E201	4	0	4
N802	3	0	3
FIX002	2	0	2
TD002	2	0	2
TD003	2	0	2
PT018	2	0	2
DTZ001	2	0	2
PT006	1	0	1
ANN202	1	0	1
ANN003	1	0	1
ARG001	1	0	1
PT012	1	0	1
ANN201	1	0	1
PLC0415	1	0	1
E225	1	0	1
E241	1	0	1
PLR0402	1	0	1

tjkuson · 2023-12-21T19:37:17Z

@charliermarsh The PR has been rebased and now forgives private name imports that are used for type annotations!

codspeed-hq · 2023-12-29T10:18:18Z

CodSpeed Performance Report

Merging #5920 will improve performances by ×4.9

_{Comparing tjkuson:import-private-name (c98ef43) with main (c6d8076)}

Summary

⚡ 15 improvements
✅ 15 untouched benchmarks

Benchmarks breakdown

	Benchmark	`main`	`tjkuson:import-private-name`	Change
⚡	`linter/all-rules[numpy/globals.py]`	4.2 ms	3 ms	+38.1%
⚡	`linter/default-rules[large/dataset.py]`	92.7 ms	19 ms	×4.9
⚡	`linter/all-rules[unicode/pypinyin.py]`	16.8 ms	12.3 ms	+36.93%
⚡	`linter/all-rules[pydantic/types.py]`	77 ms	48.5 ms	+58.64%
⚡	`linter/all-rules[numpy/ctypeslib.py]`	36.1 ms	23.3 ms	+54.91%
⚡	`linter/default-rules[numpy/globals.py]`	1,799.7 µs	635.5 µs	×2.8
⚡	`linter/all-with-preview-rules[numpy/ctypeslib.py]`	39.3 ms	26.5 ms	+48.23%
⚡	`linter/all-with-preview-rules[pydantic/types.py]`	85.3 ms	55.9 ms	+52.41%
⚡	`linter/all-with-preview-rules[numpy/globals.py]`	4.5 ms	3.4 ms	+34.15%
⚡	`linter/default-rules[numpy/ctypeslib.py]`	16.9 ms	4 ms	×4.2
⚡	`linter/default-rules[unicode/pypinyin.py]`	6 ms	1.5 ms	×4.1
⚡	`linter/all-rules[large/dataset.py]`	176 ms	102.5 ms	+71.67%
⚡	`linter/default-rules[pydantic/types.py]`	36.2 ms	8.4 ms	×4.3
⚡	`linter/all-with-preview-rules[unicode/pypinyin.py]`	17.9 ms	13.4 ms	+33.11%
⚡	`linter/all-with-preview-rules[large/dataset.py]`	198.4 ms	122 ms	+62.57%

charliermarsh · 2024-01-16T04:34:32Z

Sorry, this is blocked on me, I've just been slow to get to it.

charliermarsh · 2024-01-16T05:11:45Z

Great work @tjkuson.

MichaReiser · 2024-01-16T08:24:36Z

I'm going to revert this change. It's panicking in the pydantic benchmark run (see https://github.com/astral-sh/ruff/actions/runs/7537305800/job/20516059364?pr=5920).

Includes fix for incorrect slice in astral-sh#5920.

## Summary #5920 with a fix for the erroneous slice in `module_name`. Fixes #9547. ## Test Plan Added `import bbb.ccc._ddd as eee` to the test fixture to ensure it no longer panics. `cargo test`

charliermarsh changed the title ~~[pylint] Impliment import-private-name (C2701)~~ [pylint] Implement import-private-name (C2701) Jul 24, 2023

konstin approved these changes Aug 1, 2023

View reviewed changes

tjkuson force-pushed the import-private-name branch from 513614f to 542d555 Compare August 1, 2023 12:11

tjkuson marked this pull request as ready for review August 2, 2023 10:55

konstin requested a review from charliermarsh August 2, 2023 12:16

tjkuson mentioned this pull request Nov 29, 2023

[pylint] - implement C2701 import-private-name #8903

Closed

Add import-private-name rule

63f6fee

tjkuson force-pushed the import-private-name branch from 95d3ae8 to 63f6fee Compare December 21, 2023 17:29

tjkuson marked this pull request as draft December 21, 2023 17:33

tjkuson added 4 commits December 21, 2023 18:50

Defer

ca89ab2

Minor tweaks

288c466

Ignore imports used for typing

3e28855

Document that type imports are ignored

44cc626

tjkuson marked this pull request as ready for review December 21, 2023 19:36

Check non-from imports

c98ef43

charliermarsh mentioned this pull request Jan 10, 2024

Add private function calls check to make sure there isn't one being called outside of the module it was defined #9138

Closed

charliermarsh added rule Implementing or modifying a lint rule preview Related to preview mode features labels Jan 16, 2024

charliermarsh added 2 commits January 15, 2024 23:57

Merge branch 'main' into import-private-name

10c08c8

Tweak typing rules

bd483d3

charliermarsh approved these changes Jan 16, 2024

View reviewed changes

charliermarsh enabled auto-merge (squash) January 16, 2024 05:11

charliermarsh merged commit 2b60552 into astral-sh:main Jan 16, 2024

MichaReiser reviewed Jan 16, 2024

View reviewed changes

Comment thread crates/ruff_linter/src/rules/pylint/rules/import_private_name.rs

MichaReiser mentioned this pull request Jan 16, 2024

Revert "[pylint] Implement import-private-name (C2701)" #9547

Merged

tjkuson added a commit to tjkuson/ruff that referenced this pull request Jan 16, 2024

Implement import-private-name Pylint rule.

04c28a9

Includes fix for incorrect slice in astral-sh#5920.

tjkuson mentioned this pull request Jan 16, 2024

[pylint] (Re-)Implement import-private-name (C2701) #9553

Merged

tjkuson deleted the import-private-name branch January 16, 2024 21:02

branchv mentioned this pull request Jan 19, 2024

ruff 0.1.14 Homebrew/homebrew-core#160455

Merged

Conversation

tjkuson commented Jul 20, 2023 • edited by charliermarsh Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

PEP 420 namespace package limitation

Test Plan

Uh oh!

github-actions bot commented Jul 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Check Results

Ecosystem

Benchmark

Linux

Windows

Uh oh!

tjkuson commented Jul 20, 2023

Uh oh!

tjkuson commented Jul 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tjkuson commented Jul 27, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AiyionPrime commented Oct 17, 2023

Uh oh!

tjkuson commented Oct 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AiyionPrime commented Oct 17, 2023

Uh oh!

charliermarsh commented Dec 12, 2023

Uh oh!

charliermarsh commented Dec 12, 2023

Uh oh!

tjkuson commented Dec 12, 2023

Uh oh!

charliermarsh commented Dec 12, 2023

Uh oh!

tjkuson commented Dec 12, 2023

Uh oh!

charliermarsh commented Dec 12, 2023

Uh oh!

tjkuson commented Dec 21, 2023

Uh oh!

github-actions bot commented Dec 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

ruff-ecosystem results

Linter (stable)

Linter (preview)

Uh oh!

tjkuson commented Dec 21, 2023

Uh oh!

codspeed-hq bot commented Dec 29, 2023

CodSpeed Performance Report

Merging #5920 will improve performances by ×4.9

Summary

Benchmarks breakdown

Uh oh!

charliermarsh commented Jan 16, 2024

Uh oh!

charliermarsh commented Jan 16, 2024

Uh oh!

MichaReiser commented Jan 16, 2024

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

tjkuson commented Jul 20, 2023 •

edited by charliermarsh

Loading

github-actions bot commented Jul 20, 2023 •

edited

Loading

tjkuson commented Jul 20, 2023 •

edited

Loading

tjkuson commented Oct 17, 2023 •

edited

Loading

github-actions bot commented Dec 21, 2023 •

edited

Loading

`ruff-ecosystem` results