[refurb] Document FURB192 exception change for empty sequences#25317
Merged
ntBre merged 1 commit intoMay 22, 2026
Conversation
`min([])` and `max([])` raise `ValueError`, while `sorted([])[0]` raises `IndexError`. Code that catches one specific exception type breaks after the autofix, so the rule documentation now calls this out alongside the existing fix-safety note about tie-breaking. Closes astral-sh#16964
|
ntBre
approved these changes
May 22, 2026
thejchap
pushed a commit
to thejchap/ruff
that referenced
this pull request
May 23, 2026
…stral-sh#25317) `sorted([])[0]` raises `IndexError`, but `min([])` and `max([])` raise `ValueError`. Code that catches one specific exception type breaks after the autofix, so the rule's fix-safety section now calls this out alongside the existing tie-breaking note. Closes astral-sh#16964
anishgirianish
pushed a commit
to anishgirianish/ruff
that referenced
this pull request
May 28, 2026
…stral-sh#25317) `sorted([])[0]` raises `IndexError`, but `min([])` and `max([])` raise `ValueError`. Code that catches one specific exception type breaks after the autofix, so the rule's fix-safety section now calls this out alongside the existing tie-breaking note. Closes astral-sh#16964
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sorted([])[0]raisesIndexError, butmin([])andmax([])raiseValueError. Code that catches one specific exception type breaks after the autofix, so the rule's fix-safety section now calls this out alongside the existing tie-breaking note.Closes #16964