[ruff] Ignore RUF029 when function is decorated with asynccontextmanager#24642
Merged
ntBre merged 2 commits intoastral-sh:mainfrom Apr 15, 2026
Merged
[ruff] Ignore RUF029 when function is decorated with asynccontextmanager#24642ntBre merged 2 commits intoastral-sh:mainfrom
ruff] Ignore RUF029 when function is decorated with asynccontextmanager#24642ntBre merged 2 commits intoastral-sh:mainfrom
Conversation
|
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| RUF029 | 10 | 0 | 10 | 0 | 0 |
| RUF100 | 4 | 4 | 0 | 0 | 0 |
ntBre
approved these changes
Apr 15, 2026
Contributor
ntBre
left a comment
There was a problem hiding this comment.
Makes sense to me, thank you!
| fn is_async_context_manager(function_def: &ast::StmtFunctionDef, semantic: &SemanticModel) -> bool { | ||
| function_def.decorator_list.iter().any(|decorator| { | ||
| semantic | ||
| .resolve_qualified_name(&decorator.expression) |
Contributor
There was a problem hiding this comment.
Just noting that we usually use map_callable on decorators to support the case where they're called, but this doesn't seem to be supported for asynccontextmanager:
>>> from contextlib import asynccontextmanager
>>> @asynccontextmanager()
... def foo(): ...
...
Traceback (most recent call last):
File "<python-input-1>", line 1, in <module>
@asynccontextmanager()
~~~~~~~~~~~~~~~~~~~^^
TypeError: asynccontextmanager() missing 1 required positional argument: 'func'so this seems correct in this case.
ruff] Ignore RUF029 when function is decorated with asynccontextmanagerruff] Ignore RUF029 when function is decorated with asynccontextmanager
This was referenced Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ignore
RUF029when function is decorated withasynccontextmanager. For example I ran across this when working with FastAPI lifespan https://fastapi.tiangolo.com/advanced/events/Test Plan
Test fixture added