Avoid rendering fix lines with trailing whitespace after |#24343
Merged
MichaReiser merged 1 commit intomainfrom Apr 1, 2026
Merged
Avoid rendering fix lines with trailing whitespace after |#24343MichaReiser merged 1 commit intomainfrom
|#24343MichaReiser merged 1 commit intomainfrom
Conversation
61f4752 to
132e6a7
Compare
|
132e6a7 to
c1dda87
Compare
AlexWaygood
approved these changes
Apr 1, 2026
Member
AlexWaygood
left a comment
There was a problem hiding this comment.
(didn't check through the whole diff, but the change makes sense to me!)
charliermarsh
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR changes how we render empty lines when showing fixes.
<sigil>(note the trailing whitespace)<sigil>Where
sigilis one of-,+and|.The main purpose of the whitespace is to align the diff content. But given that there isn't any, it seems unnecessary to render the