[pylint] Improve phrasing (PLC0208)#24033
Merged
ntBre merged 1 commit intoastral-sh:mainfrom Mar 18, 2026
Merged
Conversation
Since I already put a lot of thought into the grammar and style, at least we can benefit from those changes. Preemptive response: I use this linter and follow its advice because I'm not an expert programmer. If you were to give me two similar Python functions, I would probably not be able to say which function was better. On the other hand, I have exceptional training and experience as an editor and a writer. I can say whether changing one word in a draft does or does not affect the grammar, the style, the voice, or more than one. I'm gifting to Astral the benefit of my professional knowledge by editing this text. I will not, however, attempt to explain how to write gooder and more clearer and conciser itself, which required thousands of hours to learn, in this Pull Request. ... or in future Pull Requests, if I were to choose to gift my knowledge again.
Contributor
Author
|
Cf. #24002 |
|
pylint] Improve phrasing (PLC0208)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since I already put a lot of thought into the grammar and style, at least we can benefit from those changes.
Preemptive response:
I use this linter and follow its advice because I'm not an expert programmer. If you were to give me two similar Python functions, I would probably not be able to say which function was better.
On the other hand, I have exceptional training and experience as an editor and a writer. I can say whether changing one word in a draft does or does not affect the grammar, the style, the voice, or more than one.
I'm gifting to Astral the benefit of my professional knowledge by editing this text. I will not, however, attempt to explain how to write gooder and more clearer and conciser itself, which required thousands of hours to learn, in this Pull Request.
... or in future Pull Requests, if I were to choose to gift my knowledge again.
Summary
Test Plan