[flake8-bugbear] Fix misleading description for B904#23731
Merged
amyreese merged 2 commits intoastral-sh:mainfrom Mar 5, 2026
Merged
[flake8-bugbear] Fix misleading description for B904#23731amyreese merged 2 commits intoastral-sh:mainfrom
flake8-bugbear] Fix misleading description for B904#23731amyreese merged 2 commits intoastral-sh:mainfrom
Conversation
The original description incorrectly stated that without a 'from' clause, exceptions would not be chained. However, Python implicitly chains exceptions by setting __context__. This fix clarifies that: - Using 'from' explicitly sets __cause__ (recommended) - Without 'from', Python still chains via __context__ but debugging is harder Fixes: astral-sh#8736
Contributor
|
The linked issue has already been closed, but this might fix #22541 instead. I'll leave the review to Amy. |
amyreese
approved these changes
Mar 5, 2026
flake8-bugbear] Fix misleading description for B904 rule
flake8-bugbear] Fix misleading description for B904 ruleflake8-bugbear] Fix misleading description for B904
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the misleading description for the B904 rule (raise-without-from-inside-except).
The Issue
The original documentation incorrectly stated that without a 'from' clause, exceptions would not be chained. However, Python implicitly chains exceptions by setting
__context__.The Fix
The fix clarifies that:
fromexplicitly sets__cause__(recommended)from, Python still chains via__context__but debugging is slightly harderFixes: #22541