[ruff] docs: Clarify first-party import detection in Ruff#23591
Merged
amyreese merged 1 commit intoastral-sh:mainfrom Feb 26, 2026
Merged
[ruff] docs: Clarify first-party import detection in Ruff#23591amyreese merged 1 commit intoastral-sh:mainfrom
amyreese merged 1 commit intoastral-sh:mainfrom
Conversation
Clarify the explanation of how Ruff determines first-party imports based on Python package structure.
Contributor
Author
|
Alternatively, happy to make a PR to remove the "requires a |
amyreese
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clarify the explanation of how Ruff determines first-party imports based on Python package structure.
This behavior kinda makes sense (if you consider implicit namespace packages implying the Python package is potentially "not-this-package"), but is also surprising.
(See #23590 for some context)
Test Plan
N/A - its docs