[ruff] Ignore "unknown" rule codes in RUF100 when RUF102 is enabled#23531
Merged
[ruff] Ignore "unknown" rule codes in RUF100 when RUF102 is enabled#23531
ruff] Ignore "unknown" rule codes in RUF100 when RUF102 is enabled#23531Conversation
|
ruff] Ignore "unknown" rule codes in RUF100 when RUF102 is enabled
ntBre
reviewed
Feb 24, 2026
ntBre
approved these changes
Feb 25, 2026
Contributor
ntBre
left a comment
There was a problem hiding this comment.
We might want to add a ## See also section to both rules pointing to the other one, but this otherwise makes sense to me. Example from UP046: https://docs.astral.sh/ruff/rules/non-pep695-generic-class/#see-also
59ca2f2 to
1ae50a7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, any
#noqawith an unknown/invalid rule code (eg,from a flake8 plugin we don't support) would generate both a RUF100
(unused noqa) diagnostic as well as RUF102 (invalid rule code).
When both rules are enabled, this would create an "overlap" between
the two rules, resulting in duplicate diagnostics as well as confusing
behavior when dealing with fixes from one or the other.
This modifies the RUF100 rule to ignore unknown codes, and only
report diagnostics for known codes that are unused.
Issue #23456