[ruff] Add unnecessary-assign-before-yield (RUF070)#23300
Merged
ntBre merged 6 commits intoastral-sh:mainfrom Feb 20, 2026
Merged
[ruff] Add unnecessary-assign-before-yield (RUF070)#23300ntBre merged 6 commits intoastral-sh:mainfrom
ruff] Add unnecessary-assign-before-yield (RUF070)#23300ntBre merged 6 commits intoastral-sh:mainfrom
Conversation
|
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| RUF070 | 82 | 82 | 0 | 0 | 0 |
Closed
amyreese
reviewed
Feb 18, 2026
crates/ruff_linter/src/rules/ruff/rules/unnecessary_assign_before_yield.rs
Show resolved
Hide resolved
crates/ruff_linter/src/rules/ruff/rules/unnecessary_assign_before_yield.rs
Outdated
Show resolved
Hide resolved
ntBre
reviewed
Feb 19, 2026
Contributor
ntBre
left a comment
There was a problem hiding this comment.
Thank you! This looks good to me overall, just a few minor simplification and test suggestions.
...ter/src/rules/ruff/snapshots/ruff_linter__rules__ruff__tests__preview__RUF070_RUF070.py.snap
Show resolved
Hide resolved
crates/ruff_linter/src/rules/ruff/rules/unnecessary_assign_before_yield.rs
Outdated
Show resolved
Hide resolved
crates/ruff_linter/src/rules/ruff/rules/unnecessary_assign_before_yield.rs
Outdated
Show resolved
Hide resolved
crates/ruff_linter/src/rules/ruff/rules/unnecessary_assign_before_yield.rs
Outdated
Show resolved
Hide resolved
crates/ruff_linter/src/rules/ruff/rules/unnecessary_assign_before_yield.rs
Outdated
Show resolved
Hide resolved
crates/ruff_linter/src/rules/ruff/rules/unnecessary_assign_before_yield.rs
Show resolved
Hide resolved
crates/ruff_linter/src/rules/ruff/rules/unnecessary_assign_before_yield.rs
Outdated
Show resolved
Hide resolved
crates/ruff_linter/src/rules/ruff/rules/unnecessary_assign_before_yield.rs
Outdated
Show resolved
Hide resolved
crates/ruff_linter/src/rules/ruff/rules/unnecessary_assign_before_yield.rs
Outdated
Show resolved
Hide resolved
crates/ruff_linter/src/rules/ruff/rules/unnecessary_assign_before_yield.rs
Show resolved
Hide resolved
ntBre
reviewed
Feb 19, 2026
Contributor
ntBre
left a comment
There was a problem hiding this comment.
Nice, thank you! This looks good overall, just a couple remaining questions about the weird yield yield case and the special with handling I saw in RET504.
crates/ruff_linter/src/rules/ruff/rules/unnecessary_assign_before_yield.rs
Show resolved
Hide resolved
crates/ruff_linter/src/rules/ruff/rules/unnecessary_assign_before_yield.rs
Show resolved
Hide resolved
Contributor
Author
|
Thanks for the detailed review, @ntBre and @amyreese! I've pushed updates addressing all the feedback:
Happy to adjust anything further! |
amyreese
approved these changes
Feb 20, 2026
ntBre
approved these changes
Feb 20, 2026
Contributor
ntBre
left a comment
There was a problem hiding this comment.
Thank you! I pushed one commit reusing the has_conditional_body implementation from flake8_return instead of copying it over. It's slightly unusual to share code across rule modules, but I think it's preferable to duplicating the helper function.
knutwannheden
pushed a commit
to openrewrite/ruff
that referenced
this pull request
Feb 20, 2026
…23300) ## Summary Closes astral-sh#13141 Adds a new rule `unnecessary-assign-before-yield` (`RUF070`) that detects variable assignments immediately followed by a `yield` (or `yield from`) of that variable, where the variable is not referenced anywhere else. This is the `yield` equivalent of `RET504` (`unnecessary-assign`). ```python # Before def gen(): x = 1 yield x # After def gen(): yield 1 ``` Unlike return, yield does not exit the function, so the rule only triggers when the binding has exactly one reference (the yielditself). The fix is marked as unsafe for the same reason. ## Test Plan cargo nextest run -p ruff_linter -- RUF070 --------- Co-authored-by: Brent Westbrook <brentrwestbrook@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #13141
Adds a new rule
unnecessary-assign-before-yield(RUF070) that detects variable assignments immediately followed by ayield(oryield from) of that variable, where the variable is not referenced anywhere else. This is theyieldequivalent ofRET504(unnecessary-assign).Unlike return, yield does not exit the function, so the rule only triggers when the binding has exactly one reference (the yielditself). The fix is marked as unsafe for the same reason.
Test Plan
cargo nextest run -p ruff_linter -- RUF070