[`pylint`] Implement `swap-with-temporary-variable` (`PLR1712`) by Bnyro · Pull Request #22205 · astral-sh/ruff

Bnyro · 2025-12-26T11:15:04Z

Summary

This PR implements the consider-swap-variables rule from pylint. Basically it tries to find code parts that swap two variables with each other using a temporary variable.

Example code:

temp = x
x = y
y = temp

can be simplified to

x, y = y, x

I've added new snapshots tests.

PS: Since this is my first contribution here and I'm not too familiar with the codebase, suggestions are very welcome! The implementation might also not be 100% memory-optimized yet, since we use clone a few times.

ntBre

Thank you! This looks good to me overall, just a few comments.

crates/ruff_linter/src/rules/pylint/rules/consider_swap_variables.rs

astral-sh-bot · 2025-12-29T14:20:41Z

`ruff-ecosystem` results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

ℹ️ ecosystem check detected linter changes. (+405 -32412 violations, +0 -0 fixes in 32 projects; 24 projects unchanged)

aiven/aiven-client (+0 -41 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --no-fix --output-format concise --preview

- aiven/client/__main__.py:1:1: I001 [*] Import block is un-sorted or un-formatted
- aiven/client/argx.py:111:9: SIM102 Use a single `if` statement instead of nested `if` statements
- aiven/client/argx.py:112:13: SIM102 Use a single `if` statement instead of nested `if` statements
- aiven/client/argx.py:5:1: I001 [*] Import block is un-sorted or un-formatted
- aiven/client/cli.py:2854:20: C417 Unnecessary `map()` usage (rewrite using a list comprehension)
- aiven/client/cli.py:2903:22: C417 Unnecessary `map()` usage (rewrite using a list comprehension)
- aiven/client/cli.py:324:35: FURB167 [*] Use of regular expression alias `re.I`
- aiven/client/cli.py:4162:9: SIM102 Use a single `if` statement instead of nested `if` statements
- aiven/client/cli.py:5209:13: SIM102 Use a single `if` statement instead of nested `if` statements
- aiven/client/cli.py:559:27: TRY201 Use `raise` without specifying exception name
... 31 additional changes omitted for project

PlasmaPy/PlasmaPy (+15 -74 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --no-fix --output-format concise --preview

- .github/scripts/authors_in_cff.py:60:9: LOG015 `info()` call on root logger
- .github/scripts/authors_in_cff.py:92:5: LOG015 `info()` call on root logger
+ docs/conf.py: panic: Panicked at crates/ruff_python_semantic/src/definition.rs:285:26 when checking `/home/runner/work/ruff/ruff/checkouts/PlasmaPy:PlasmaPy/docs/conf.py`: `index out of bounds: the len is 0 but the index is 0`
- docs/conf.py:39:8: PLC2701 Private name import `_author_list_from_cff`
- docs/conf.py:40:8: PLC2701 Private name import `_changelog_index`
- docs/conf.py:41:8: PLC2701 Private name import `_global_substitutions`
- docs/conf.py:59:5: LOG015 `info()` call on root logger
- docs/conf.py:63:5: LOG015 `warning()` call on root logger
+ docs/notebooks/formulary/braginskii.ipynb: panic: Panicked at crates/ruff_python_semantic/src/definition.rs:285:26 when checking `/home/runner/work/ruff/ruff/checkouts/PlasmaPy:PlasmaPy/docs/notebooks/formulary/braginskii.ipynb`: `index out of bounds: the len is 0 but the index is 0`
- src/plasmapy/__init__.py:13:11: RUF022 [*] `__all__` is not sorted
... 79 additional changes omitted for project

apache/airflow (+84 -6274 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --no-fix --output-format concise --preview --select ALL

+ airflow-core/docs/conf.py: panic: Panicked at crates/ruff_python_semantic/src/definition.rs:285:26 when checking `/home/runner/work/ruff/ruff/checkouts/apache:airflow/airflow-core/docs/conf.py`: `index out of bounds: the len is 0 but the index is 0`
- airflow-core/docs/conf.py:107:6: COM812 [*] Trailing comma missing
- airflow-core/docs/conf.py:146:5: ANN201 Missing return type annotation for public function `add_airflow_core_exclude_patterns_to_sphinx`
- airflow-core/docs/conf.py:168:13: PERF401 Use `list.extend` to create a transformed list
- airflow-core/docs/conf.py:172:13: PERF401 Use `list.extend` to create a transformed list
- airflow-core/docs/conf.py:1:1: CPY001 Missing copyright notice at top of file
- airflow-core/docs/conf.py:1:1: INP001 File `airflow-core/docs/conf.py` is part of an implicit namespace package. Add an `__init__.py`.
- airflow-core/docs/conf.py:241:19: COM812 [*] Trailing comma missing
- airflow-core/docs/conf.py:247:3: FIX002 Line contains TODO, consider resolving the issue
- airflow-core/docs/conf.py:247:3: TD002 Missing author in TODO; try: `# TODO(): ...` or `# TODO @: ...`
... 6348 additional changes omitted for project

apache/superset (+14 -1147 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --no-fix --output-format concise --preview --select ALL

+ docker/pythonpath_dev/superset_config.py: panic: Panicked at crates/ruff_python_semantic/src/definition.rs:285:26 when checking `/home/runner/work/ruff/ruff/checkouts/apache:superset/docker/pythonpath_dev/superset_config.py`: `index out of bounds: the len is 0 but the index is 0`
- docker/pythonpath_dev/superset_config.py:123:16: PTH120 `os.path.dirname()` should be replaced by `Path.parent`
- docker/pythonpath_dev/superset_config.py:124:21: PTH100 `os.path.abspath()` should be replaced by `Path.resolve()`
- docker/pythonpath_dev/superset_config.py:125:65: COM812 [*] Trailing comma missing
- docker/pythonpath_dev/superset_config.py:125:9: PTH118 `os.path.join()` should be replaced by `Path` with `/` operator
- docker/pythonpath_dev/superset_config.py:128:41: PGH004 Use specific rule codes when using `noqa`
- docker/pythonpath_dev/superset_config.py:141:84: COM812 [*] Trailing comma missing
- docker/pythonpath_dev/superset_config.py:1:1: CPY001 Missing copyright notice at top of file
- docker/pythonpath_dev/superset_config.py:1:1: D100 Missing docstring in public module
- docker/pythonpath_dev/superset_config.py:1:1: INP001 File `docker/pythonpath_dev/superset_config.py` is part of an implicit namespace package. Add an `__init__.py`.
... 1151 additional changes omitted for project

aws/aws-sam-cli (+4 -10 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --no-fix --output-format concise --preview

+ installer/pyinstaller/hook-samcli.py: panic: Panicked at crates/ruff_python_semantic/src/definition.rs:285:26 when checking `/home/runner/work/ruff/ruff/checkouts/aws:aws-sam-cli/installer/pyinstaller/hook-samcli.py`: `index out of bounds: the len is 0 but the index is 0`
- installer/pyinstaller/hook-samcli.py:1:1: I001 [*] Import block is un-sorted or un-formatted
+ samcli/commands/common/execution/history/options.py: panic: Panicked at crates/ruff_python_semantic/src/definition.rs:285:26 when checking `/home/runner/work/ruff/ruff/checkouts/aws:aws-sam-cli/samcli/commands/common/execution/history/options.py`: `index out of bounds: the len is 0 but the index is 0`
+ samcli/hook_packages/terraform/copy_terraform_built_artifacts.py: panic: Panicked at crates/ruff_python_semantic/src/definition.rs:285:26 when checking `/home/runner/work/ruff/ruff/checkouts/aws:aws-sam-cli/samcli/hook_packages/terraform/copy_terraform_built_artifacts.py`: `index out of bounds: the len is 0 but the index is 0`
+ tests/unit/commands/pipeline/bootstrap/test_guided_context.py: panic: Panicked at crates/ruff_python_semantic/src/definition.rs:285:26 when checking `/home/runner/work/ruff/ruff/checkouts/aws:aws-sam-cli/tests/unit/commands/pipeline/bootstrap/test_guided_context.py`: `index out of bounds: the len is 0 but the index is 0`
- tests/unit/commands/pipeline/bootstrap/test_guided_context.py:119:9: PLR6301 Method `test_guided_context_will_not_prompt_for_fields_that_are_already_provided_oidc_gitlab` could be a function, class method, or static method
- tests/unit/commands/pipeline/bootstrap/test_guided_context.py:1:1: I001 [*] Import block is un-sorted or un-formatted
- tests/unit/commands/pipeline/bootstrap/test_guided_context.py:37:9: PLR6301 Method `test_guided_context_will_not_prompt_for_fields_that_are_already_provided` could be a function, class method, or static method
- tests/unit/commands/pipeline/bootstrap/test_guided_context.py:412:9: PLR6301 Method `test_prompt_account_id_can_display_profiles_and_environment` could be a function, class method, or static method
- tests/unit/commands/pipeline/bootstrap/test_guided_context.py:431:9: PLR6301 Method `test_prompt_account_id_wont_show_environment_option_when_it_doesnt_exist` could be a function, class method, or static method
... 4 additional changes omitted for project

bokeh/bokeh (+28 -1382 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --no-fix --output-format concise --preview --select ALL

+ docs/bokeh/source/docs/first_steps/examples/first_steps_6_row_layout.py: panic: Panicked at crates/ruff_python_semantic/src/definition.rs:285:26 when checking `/home/runner/work/ruff/ruff/checkouts/bokeh:bokeh/docs/bokeh/source/docs/first_steps/examples/first_steps_6_row_layout.py`: `index out of bounds: the len is 0 but the index is 0`
- docs/bokeh/source/docs/first_steps/examples/first_steps_6_row_layout.py:1:1: CPY001 Missing copyright notice at top of file
- docs/bokeh/source/docs/first_steps/examples/first_steps_6_row_layout.py:1:1: D100 Missing docstring in public module
- docs/bokeh/source/docs/first_steps/examples/first_steps_6_row_layout.py:1:1: INP001 File `docs/bokeh/source/docs/first_steps/examples/first_steps_6_row_layout.py` is part of an implicit namespace package. Add an `__init__.py`.
+ docs/bokeh/source/docs/first_steps/examples/first_steps_6_row_layout_responsive.py: panic: Panicked at crates/ruff_python_semantic/src/definition.rs:285:26 when checking `/home/runner/work/ruff/ruff/checkouts/bokeh:bokeh/docs/bokeh/source/docs/first_steps/examples/first_steps_6_row_layout_responsive.py`: `index out of bounds: the len is 0 but the index is 0`
- docs/bokeh/source/docs/first_steps/examples/first_steps_6_row_layout_responsive.py:1:1: CPY001 Missing copyright notice at top of file
- docs/bokeh/source/docs/first_steps/examples/first_steps_6_row_layout_responsive.py:1:1: D100 Missing docstring in public module
- docs/bokeh/source/docs/first_steps/examples/first_steps_6_row_layout_responsive.py:1:1: INP001 File `docs/bokeh/source/docs/first_steps/examples/first_steps_6_row_layout_responsive.py` is part of an implicit namespace package. Add an `__init__.py`.
+ examples/advanced/extensions/widget.py: panic: Panicked at crates/ruff_python_semantic/src/definition.rs:285:26 when checking `/home/runner/work/ruff/ruff/checkouts/bokeh:bokeh/examples/advanced/extensions/widget.py`: `index out of bounds: the len is 0 but the index is 0`
- examples/advanced/extensions/widget.py:15:22: RUF012 Mutable default value for class attribute
... 1400 additional changes omitted for project

docker/docker-py (+0 -209 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --no-fix --output-format concise --preview

- docker/api/build.py:128:9: SIM102 Use a single `if` statement instead of nested `if` statements
- docker/api/build.py:133:13: SIM118 Use `key in dict` instead of `key in dict.keys()`
- docker/api/client.py:259:17: TRY004 Prefer `TypeError` exception for invalid type
- docker/api/client.py:296:21: PERF403 Use `dict.update` instead of a for-loop
- docker/api/client.py:512:23: TRY201 Use `raise` without specifying exception name
- docker/api/container.py:867:13: SIM114 [*] Combine `if` branches using logical `or` operator
- docker/api/container.py:884:13: SIM114 [*] Combine `if` branches using logical `or` operator
- docker/api/image.py:401:19: RUF059 Unpacked variable `repo_name` is never used
- docker/api/image.py:476:19: RUF059 Unpacked variable `repo_name` is never used
- docker/api/plugin.py:132:19: RUF059 Unpacked variable `repo_name` is never used
... 199 additional changes omitted for project

facebookresearch/chameleon (+0 -303 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --no-fix --output-format concise --preview

- chameleon/inference/alignment.py:13:38: FA102 Missing `from __future__ import annotations`, but uses PEP 585 collection
- chameleon/inference/alignment.py:13:43: FA102 Missing `from __future__ import annotations`, but uses PEP 585 collection
- chameleon/inference/alignment.py:17:41: FA102 Missing `from __future__ import annotations`, but uses PEP 585 collection
- chameleon/inference/alignment.py:17:46: FA102 Missing `from __future__ import annotations`, but uses PEP 585 collection
- chameleon/inference/alignment.py:31:38: FA102 Missing `from __future__ import annotations`, but uses PEP 585 collection
- chameleon/inference/alignment.py:31:43: FA102 Missing `from __future__ import annotations`, but uses PEP 585 collection
... 261 additional changes omitted for rule FA102
- chameleon/inference/chameleon.py:433:12: FA100 Add `from __future__ import annotations` to simplify `typing.Union`
- chameleon/inference/chameleon.py:434:12: FA100 Add `from __future__ import annotations` to simplify `typing.Union`
- chameleon/inference/chameleon.py:435:17: FA100 Add `from __future__ import annotations` to simplify `typing.Union`
- chameleon/inference/chameleon.py:436:22: FA100 Add `from __future__ import annotations` to simplify `typing.Union`
... 293 additional changes omitted for project

... Truncated remaining completed project reports due to GitHub comment length restrictions

Changes by rule (409 rules affected)

code	total	+ violation	- violation
UP045	5895	0	5895
FA102	3016	0	3016
UP006	2226	0	2226
C408	1469	0	1469
ANN001	1374	0	1374
UP037	1130	0	1130
UP007	905	0	905
COM812	835	0	835
ANN201	815	0	815
UP035	814	0	814
RUF100	677	0	677
FA100	547	0	547
RET504	480	0	480
PLR6301	462	0	462
B008	446	0	446
BLE001	374	0	374
panic:	370	370	0
DOC201	370	0	370
D212	369	0	369
SIM117	314	0	314
ERA001	300	0	300
ANN202	256	0	256
RUF012	223	0	223
D102	209	0	209
TRY003	199	0	199
PLC0415	196	0	196
SIM102	191	0	191
E265	180	0	180
RUF059	179	0	179
D103	163	0	163
ARG002	161	0	161
Q000	161	0	161
CPY001	138	0	138
RUF067	137	0	137
ANN401	132	0	132
TRY002	129	0	129
TRY300	127	0	127
I001	125	0	125
PERF401	116	0	116
S101	112	0	112
DTZ001	110	0	110
PLR0917	107	0	107
D205	104	0	104
EM102	103	0	103
EM101	99	0	99
T201	99	0	99
AIR311	98	0	98
DOC501	97	0	97
E501	93	0	93
RUF022	89	0	89
E302	89	0	89
PLR0402	87	0	87
FBT001	86	0	86
E402	85	13	72
PTH118	82	0	82
C419	81	0	81
TRY004	74	0	74
SLF001	73	0	73
ANN204	73	0	73
PYI036	73	0	73
PLR6201	71	0	71
TRY201	70	0	70
D100	70	0	70
PLR0913	69	0	69
SIM118	69	0	69
FBT002	67	0	67
ANN003	66	0	66
FIX002	64	0	64
AIR001	64	0	64
RUF015	64	0	64
TD002	63	0	63
TD003	63	0	63
D101	62	0	62
D401	62	0	62
D107	61	0	61
FLY002	61	0	61
SIM115	60	0	60
D210	58	0	58
TID252	58	0	58
PYI063	56	0	56
ARG003	53	0	53
B018	53	0	53
LOG015	51	0	51
D415	49	0	49
B006	49	0	49
PLR2004	48	0	48
D400	48	0	48
PIE790	46	0	46
RUF010	45	0	45
ARG001	44	0	44
Q002	43	0	43
S110	43	0	43
C901	42	0	42
RET505	42	0	42
PYI034	42	0	42
D300	41	0	41
SIM103	40	0	40
PLR1714	38	0	38
TC003	36	0	36
D105	34	0	34
SIM114	34	0	34
B009	34	0	34
G201	34	0	34
B010	33	0	33
RUF013	33	0	33
RET501	32	0	32
D200	32	0	32
DTZ005	31	0	31
B904	30	0	30
PLR1704	30	0	30
INP001	29	0	29
PTH123	29	0	29
C401	28	0	28
PLR6104	28	0	28
PLC2701	27	0	27
RUF052	27	0	27
PYI032	27	0	27
C402	27	0	27
PLR0912	26	0	26
E261	26	0	26
PERF402	26	0	26
PIE804	26	0	26
RUF036	25	0	25
A002	24	0	24
PYI041	23	0	23
PLC0414	23	0	23
PTH120	22	0	22
PLW0603	22	0	22
S106	21	0	21
TC006	21	0	21
E305	21	0	21
UP032	21	0	21
PT007	20	0	20
PLR0904	19	0	19
PLW1508	19	0	19
PLW1510	19	0	19
B015	19	0	19
UP012	19	0	19
UP030	19	0	19
E241	18	0	18
E251	18	0	18
PLR1711	18	0	18
PT031	18	0	18
C403	18	0	18
D404	17	0	17
FURB118	17	0	17
PLW1514	17	0	17
D202	17	0	17
D419	17	0	17
PT014	17	0	17
C405	17	0	17
PIE807	17	0	17
PYI055	17	0	17
RUF031	16	0	16
SIM108	16	0	16
PGH003	16	0	16
N815	16	0	16
TC002	16	0	16
C413	16	0	16
S102	16	0	16
PLR0914	15	0	15
PTH100	15	0	15
ANN205	15	0	15
PYI016	15	0	15
PYI066	15	0	15
F403	14	14	0
FBT003	14	0	14
PLR0915	14	0	14
PLR1702	14	0	14
DOC402	14	0	14
TRY400	14	0	14
PLW0602	14	0	14
PYI019	14	0	14
ANN002	13	0	13
AIR321	13	0	13
D209	13	0	13
PIE808	13	0	13
PLW3201	13	0	13
UP004	13	0	13
ISC004	12	0	12
D204	12	0	12
C417	11	0	11
TD004	11	0	11
PLC1901	11	0	11
PYI059	11	0	11
PIE810	11	0	11
PERF102	11	0	11
TRY401	10	0	10
RSE102	10	0	10
SIM201	10	0	10
FURB101	10	0	10
UP031	10	0	10
PLC0208	10	0	10
B017	10	0	10
UP009	10	0	10
E266	10	0	10
PLR0911	9	0	9
RUF069	9	0	9
PTH110	9	0	9
UP034	9	0	9
SIM101	9	0	9
C414	9	0	9
E712	8	8	0
FIX004	8	0	8
TD006	8	0	8
N806	8	0	8
S108	8	0	8
PLC2801	8	0	8
PT019	8	0	8
RET503	8	0	8
PIE800	8	0	8
TRY203	8	0	8
PLR0133	8	0	8
PTH103	8	0	8
ANN206	7	0	7
C416	7	0	7
PTH119	7	0	7
TC001	7	0	7
RUF065	7	0	7
B023	7	0	7
PLR1722	7	0	7
PLC0206	7	0	7
UP024	7	0	7
C400	7	0	7
B026	7	0	7
FURB177	7	0	7
G202	7	0	7
LOG014	7	0	7
EXE001	6	0	6
S105	6	0	6
S404	6	0	6
ARG004	6	0	6
RUF043	6	0	6
FURB189	6	0	6
E221	6	0	6
E201	6	0	6
E202	6	0	6
A001	6	0	6
PLW0127	6	0	6
PLR2044	6	0	6
PLW0120	6	0	6
RUF018	6	0	6
RUF023	6	0	6
FURB167	5	0	5
PLR5501	5	0	5
FURB110	5	0	5
S403	5	0	5
ARG005	5	0	5
PGH004	5	0	5
E226	5	0	5
PERF403	5	0	5
UP036	5	0	5
PLR1733	5	0	5
TC004	5	0	5
PLR0124	5	0	5
SIM905	5	0	5
RUF001	5	0	5
FURB103	5	0	5
PLR0916	5	0	5
FURB140	4	0	4
PERF203	4	0	4
RUF027	4	0	4
PTH107	4	0	4
TD005	4	0	4
D413	4	0	4
DOC202	4	0	4
PYI030	4	0	4
D208	4	0	4
S603	4	0	4
FURB188	4	0	4
SIM113	4	0	4
SIM210	4	0	4
RUF029	4	0	4
RUF003	4	0	4
DTZ007	4	0	4
FURB136	4	0	4
DTZ011	4	0	4
PTH124	4	0	4
S607	4	0	4
PTH207	4	0	4
TRY301	3	0	3
PLR1730	3	0	3
PTH111	3	0	3
FURB154	3	0	3
FURB142	3	0	3
FURB113	3	0	3
B905	3	0	3
FURB129	3	0	3
S608	3	0	3
TD001	3	0	3
N802	3	0	3
S113	3	0	3
D418	3	0	3
PLW2901	3	0	3
D417	3	0	3
B007	3	0	3
RET506	3	0	3
PYI061	3	0	3
PLE0704	3	0	3
LOG009	3	0	3
TC005	3	0	3
B020	3	0	3
SIM211	3	0	3
B033	3	0	3
N999	3	0	3
PT018	3	0	3
PIE796	2	0	2
RUF021	2	0	2
PTH117	2	0	2
PYI024	2	0	2
DTZ901	2	0	2
PTH208	2	0	2
PLR1736	2	0	2
SIM910	2	0	2
D104	2	0	2
RUF002	2	0	2
SIM105	2	0	2
PD011	2	0	2
DOC102	2	0	2
D412	2	0	2
FIX003	2	0	2
S314	2	0	2
ICN001	2	0	2
N813	2	0	2
S405	2	0	2
EXE002	2	0	2
DTZ004	2	0	2
PLE1205	2	0	2
DOC502	2	0	2
F541	2	0	2
PLW0128	2	0	2
PIE794	2	0	2
YTT103	2	0	2
UP010	2	0	2
PLC0205	2	0	2
UP028	2	0	2
PLC0105	2	0	2
SIM223	2	0	2
PYI025	2	0	2
UP018	2	0	2
FURB105	2	0	2
LOG004	2	0	2
PTH108	2	0	2
PTH116	2	0	2
PTH113	2	0	2
FURB157	1	0	1
N817	1	0	1
N805	1	0	1
AIR002	1	0	1
N803	1	0	1
SIM401	1	0	1
FURB171	1	0	1
PTH106	1	0	1
FIX001	1	0	1
S301	1	0	1
SIM110	1	0	1
RUF005	1	0	1
S104	1	0	1
F401	1	0	1
NPY002	1	0	1
E225	1	0	1
Q001	1	0	1
N812	1	0	1
E303	1	0	1
RET508	1	0	1
E301	1	0	1
E227	1	0	1
PTH109	1	0	1
ISC003	1	0	1
E203	1	0	1
FURB148	1	0	1
PLW1509	1	0	1
PLW0133	1	0	1
PLW0211	1	0	1
PYI013	1	0	1
B903	1	0	1
UP014	1	0	1
RUF007	1	0	1
S112	1	0	1
B012	1	0	1
PLW0642	1	0	1
B013	1	0	1
YTT301	1	0	1
DTZ006	1	0	1
B039	1	0	1
UP011	1	0	1
FURB163	1	0	1
PLW0129	1	0	1
B030	1	0	1
RUF051	1	0	1
LOG001	1	0	1
DTZ002	1	0	1
RUF019	1	0	1
DTZ003	1	0	1
PYI044	1	0	1
FURB122	1	0	1
PYI006	1	0	1
S324	1	0	1
S606	1	0	1
PTH211	1	0	1
S311	1	0	1
PTH122	1	0	1
PTH202	1	0	1
D106	1	0	1
D403	1	0	1
RUF056	1	0	1
B901	1	0	1
PYI045	1	0	1
S402	1	0	1

Bnyro · 2025-12-29T16:37:37Z

Thanks a lot for the review @ntBre!

I've applied all suggestions except for the 2 unresolved ones above where I'm not quite sure yet, I'd appreciate your thoughts on that :)

ntBre

Thank you again, this is looking great!

I had a couple more nits and one larger concern about removing the temporary variable, but even that shouldn't be too much trouble, I hope.

crates/ruff_linter/src/rules/pylint/rules/swap_with_temporary_variable.rs

crates/ruff_linter/resources/test/fixtures/pylint/swap_with_temporary_variable.py

crates/ruff_linter/src/rules/pylint/rules/swap_with_temporary_variable.rs

crates/ruff_linter/resources/test/fixtures/pylint/swap_with_temporary_variable.py

codspeed-hq · 2026-02-12T22:45:24Z

Merging this PR will not alter performance

✅ 30 untouched benchmarks
⏩ 24 skipped benchmarks¹

_{Comparing Bnyro:temporary-variable-swap (c08dea5) with main (97acaae)}

24 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

ntBre

Thank you, this is looking great! I managed to come up with a few more nits and another contrived test case that we should double check the behavior of, but otherwise I think this is good to go.

...nt/snapshots/ruff_linter__rules__pylint__tests__PLR1712_swap_with_temporary_variable.py.snap

crates/ruff_linter/resources/test/fixtures/pylint/swap_with_temporary_variable.py

crates/ruff_linter/src/rules/pylint/rules/swap_with_temporary_variable.rs

Bnyro · 2026-02-19T16:58:02Z

Thank you, this is looking great! I managed to come up with a few more nits and another contrived test case that we should double check the behavior of, but otherwise I think this is good to go.

Thanks for the review, I've addressed all the suggestions.

Your reviews helped me to learn more about the Python AST structure used in Ruff, so although the PR process took some time, it was definitely worth it. Thanks for all your help :)

ntBre

Thank you for all of your work here, this looks great to me!

I'll land this once the release is finished for today.

…al-sh#22205) ## Summary This PR implements the `consider-swap-variables` rule from pylint. Basically it tries to find code parts that swap two variables with each other using a temporary variable. Example code: ```py temp = x x = y y = temp ``` can be simplified to ```py x, y = y, x ``` related: - https://pylint.readthedocs.io/en/latest/user_guide/messages/refactor/consider-swap-variables.html - astral-sh#970  ## Test Plan I've added new snapshots tests. PS: Since this is my first contribution here and I'm not too familiar with the codebase, suggestions are very welcome! The implementation might also not be 100% memory-optimized yet, since we use `clone` a few times.

… (`PLR1712`) (#22205)" This is an alternative to #23588, checking the ecosystem results in comparison.

Summary -- The huge number of changes in #22205 (comment) should have obviously been a red flag, but I think it would be nice if CI failed when new ecosystem panics were introduced. This PR adds a check for diagnostic lines that start with `panic: Panicked at crates/`, raises a `ToolError` if any are found in the results from the comparison executable, and then also exits non-zero if any errors are returned. If exiting non-zero is going too far, we could also just raise the `ToolError`, as that will at least trigger this message, which was not the case on the PLR1712 PR: https://github.com/astral-sh/ruff/blob/f14edd8661e2803254f89265548c7487f47a09f6/python/ruff-ecosystem/ruff_ecosystem/check.py#L103-L106 Another option would be not to exit zero if Ruff panics, even if `--exit-zero` is used, but I saw that ty has the same behavior and assumed that that was intentional. Test Plan -- Local testing on the 0.15.3 tag showing that ruff-ecosystem exited non-zero. I can also introduce a panic into a lint rule to test this in CI

Summary -- The huge number of changes in #22205 (comment) should have obviously been a red flag, but I think it would be nice if CI failed when new ecosystem panics were introduced. This PR adds a check for diagnostic lines that start with `panic: Panicked at crates/`, raises a `ToolError` if any are found in the results from the comparison executable, and then ~~also exits non-zero if any errors are returned~~ fails the CI run if the corresponding error message was printed. After trying this out in CI, I opted not to change the script's exit code itself because that suppressed the ecosystem comment. It feels a little hackier this way but preserves the behavior I wanted of both failing CI and still getting the ecosystem comment to help with debugging. Test Plan -- Local testing on the 0.15.3 tag showing that ruff-ecosystem exited non-zero and some manual testing in CI, as you can see below.

ntBre added rule Implementing or modifying a lint rule preview Related to preview mode features labels Dec 29, 2025

ntBre requested changes Dec 29, 2025

View reviewed changes

Bnyro force-pushed the temporary-variable-swap branch from 9f0567d to 6edd032 Compare December 29, 2025 16:36

Bnyro force-pushed the temporary-variable-swap branch 2 times, most recently from 0519f49 to 7e79155 Compare December 29, 2025 17:47

ntBre reviewed Jan 2, 2026

View reviewed changes

ntBre changed the title ~~[pylint]: Implement consider-swap-variables (PLR1712)~~ [pylint] Implement swap-with-temporary-variable (PLR1712) Jan 2, 2026

Bnyro force-pushed the temporary-variable-swap branch from 7e79155 to df1c532 Compare January 3, 2026 12:50

MichaReiser requested a review from ntBre January 16, 2026 08:59

Bnyro force-pushed the temporary-variable-swap branch 2 times, most recently from 8971c6d to 51bbda1 Compare January 16, 2026 17:45

Bnyro force-pushed the temporary-variable-swap branch from 6a165cc to 33f02d2 Compare February 7, 2026 14:35

ntBre reviewed Feb 12, 2026

View reviewed changes

Bnyro force-pushed the temporary-variable-swap branch from 33f02d2 to 839b712 Compare February 18, 2026 19:50

ntBre reviewed Feb 19, 2026

View reviewed changes

Bnyro force-pushed the temporary-variable-swap branch from 839b712 to d022c96 Compare February 19, 2026 16:55

[pylint]: Implement swap-with-temporary-variable (PLR1712)

c08dea5

Bnyro force-pushed the temporary-variable-swap branch from d022c96 to c08dea5 Compare February 19, 2026 16:59

ntBre approved these changes Feb 19, 2026

View reviewed changes

ntBre merged commit 333ad91 into astral-sh:main Feb 19, 2026
42 checks passed

Bnyro deleted the temporary-variable-swap branch February 19, 2026 23:35

ntBre mentioned this pull request Feb 26, 2026

Fix panic on access to definitions after analyzing definitions #23588

Merged

BrewTestBot mentioned this pull request Feb 26, 2026

ruff 0.15.3 Homebrew/homebrew-core#269612

Merged

ntBre added a commit that referenced this pull request Feb 26, 2026

[testing] Revert "[pylint] Implement swap-with-temporary-variable…

daecb46

… (`PLR1712`) (#22205)" This is an alternative to #23588, checking the ecosystem results in comparison.

ntBre mentioned this pull request Feb 26, 2026

Fail CI on new linter ecosystem panics #23597

Merged

Conversation

Bnyro commented Dec 26, 2025

Summary

Test Plan

Uh oh!

ntBre left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

astral-sh-bot bot commented Dec 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

ruff-ecosystem results

Linter (stable)

Linter (preview)

Uh oh!

Bnyro commented Dec 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ntBre left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codspeed-hq bot commented Feb 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Footnotes

Uh oh!

ntBre left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Bnyro commented Feb 19, 2026

Uh oh!

ntBre left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

astral-sh-bot bot commented Dec 29, 2025 •

edited

Loading

`ruff-ecosystem` results

Bnyro commented Dec 29, 2025 •

edited

Loading

codspeed-hq bot commented Feb 12, 2026 •

edited

Loading