[`flake8-blind-except`] Allow more logging methods (`BLE001`) by lubaskinc0de · Pull Request #22057 · astral-sh/ruff

lubaskinc0de · 2025-12-18T18:40:38Z

Summary

Fix issue #21889 by checking that the logging method is one of the debug, info, warning, error, exception, critical, log methods that support exc_info passing. Also fixed the behavior in which exc_info was considered passed only when it was equal to the literal True, now the Truthiness of the expression is checked (we will leave additional checks to type checkers)

Test Plan

Additional snapshot tests have been added for all logging functions, as well as tests in which an exception object is passed as exc_info

…mpatible logging method

…ogging.log

astral-sh-bot · 2025-12-18T18:51:12Z

`ruff-ecosystem` results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

ℹ️ ecosystem check detected linter changes. (+3 -32 violations, +0 -0 fixes in 3 projects; 52 projects unchanged)

apache/airflow (+0 -26 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --no-fix --output-format concise --preview --select ALL

- airflow-core/src/airflow/api_fastapi/execution_api/app.py:152:20: BLE001 Do not catch blind exception: `Exception`
- airflow-core/src/airflow/api_fastapi/execution_api/deps.py:91:16: BLE001 Do not catch blind exception: `Exception`
- airflow-core/src/airflow/jobs/scheduler_job_runner.py:2357:20: BLE001 Do not catch blind exception: `Exception`
- airflow-core/src/airflow/models/dagrun.py:1665:16: BLE001 Do not catch blind exception: `Exception`
- airflow-core/src/airflow/utils/serve_logs/log_server.py:111:16: BLE001 Do not catch blind exception: `Exception`
- providers/amazon/src/airflow/providers/amazon/aws/utils/suppress.py:65:20: BLE001 Do not catch blind exception: `Exception`
- providers/ftp/src/airflow/providers/ftp/operators/ftp.py:158:16: BLE001 Do not catch blind exception: `Exception`
- providers/google/src/airflow/providers/google/cloud/openlineage/mixins.py:123:16: BLE001 Do not catch blind exception: `Exception`
- providers/google/src/airflow/providers/google/cloud/operators/dataproc.py:1802:16: BLE001 Do not catch blind exception: `Exception`
- providers/google/src/airflow/providers/google/cloud/operators/dataproc.py:1999:16: BLE001 Do not catch blind exception: `Exception`
- providers/google/src/airflow/providers/google/cloud/operators/dataproc.py:2589:16: BLE001 Do not catch blind exception: `Exception`
- providers/google/src/airflow/providers/google/cloud/transfers/bigquery_to_sql.py:174:16: BLE001 Do not catch blind exception: `Exception`
- providers/openlineage/src/airflow/providers/openlineage/extractors/base.py:158:16: BLE001 Do not catch blind exception: `Exception`
- providers/openlineage/src/airflow/providers/openlineage/extractors/manager.py:140:20: BLE001 Do not catch blind exception: `Exception`
- providers/openlineage/src/airflow/providers/openlineage/plugins/adapter.py:169:16: BLE001 Do not catch blind exception: `Exception`
- providers/openlineage/src/airflow/providers/openlineage/plugins/listener.py:691:16: BLE001 Do not catch blind exception: `BaseException`
- providers/openlineage/src/airflow/providers/openlineage/plugins/listener.py:743:16: BLE001 Do not catch blind exception: `BaseException`
- providers/openlineage/src/airflow/providers/openlineage/plugins/listener.py:796:16: BLE001 Do not catch blind exception: `BaseException`
- providers/openlineage/src/airflow/providers/openlineage/sqlparser.py:355:20: BLE001 Do not catch blind exception: `Exception`
- providers/openlineage/src/airflow/providers/openlineage/utils/utils.py:1352:12: BLE001 Do not catch blind exception: `Exception`
- providers/openlineage/src/airflow/providers/openlineage/utils/utils.py:1560:20: BLE001 Do not catch blind exception: `Exception`
- providers/sftp/src/airflow/providers/sftp/operators/sftp.py:236:16: BLE001 Do not catch blind exception: `Exception`
- providers/ssh/src/airflow/providers/ssh/hooks/ssh.py:508:24: BLE001 Do not catch blind exception: `Exception`
- providers/standard/src/airflow/providers/standard/utils/openlineage.py:178:12: BLE001 Do not catch blind exception: `Exception`
- task-sdk/src/airflow/sdk/execution_time/task_runner.py:963:12: BLE001 Do not catch blind exception: `Exception`
- task-sdk/src/airflow/sdk/serde/serializers/kubernetes.py:59:16: BLE001 Do not catch blind exception: `Exception`

apache/superset (+0 -6 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --no-fix --output-format concise --preview --select ALL

- superset/db_engine_specs/bigquery.py:868:16: BLE001 Do not catch blind exception: `Exception`
- superset/db_engine_specs/bigquery.py:915:16: BLE001 Do not catch blind exception: `Exception`
- superset/models/core.py:1199:20: BLE001 Do not catch blind exception: `Exception`
- superset/security/manager.py:2888:16: BLE001 Do not catch blind exception: `Exception`
- superset/utils/screenshots.py:294:16: BLE001 Do not catch blind exception: `Exception`
- superset/utils/screenshots.py:300:20: BLE001 Do not catch blind exception: `Exception`

langchain-ai/langchain (+3 -0 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --no-fix --output-format concise --preview

+ libs/langchain/langchain_classic/chains/openai_functions/openapi.py:383:32: RUF100 [*] Unused `noqa` directive (unused: `BLE001`)
+ libs/langchain/langchain_classic/smith/evaluation/runner_utils.py:1208:37: RUF100 [*] Unused `noqa` directive (unused: `BLE001`)
+ libs/langchain/langchain_classic/smith/evaluation/runner_utils.py:1216:33: RUF100 [*] Unused `noqa` directive (unused: `BLE001`)

Changes by rule (2 rules affected)

code	total	+ violation	- violation	+ fix	- fix
BLE001	32	0	32	0	0
RUF100	3	3	0	0	0

crates/ruff_linter/src/rules/flake8_blind_except/rules/blind_except.rs

…test-cases for ``logging.warn`

crates/ruff_linter/src/rules/flake8_blind_except/rules/blind_except.rs

crates/ruff_linter/src/rules/flake8_logging/rules/root_logger_call.rs

…ng::helpers``

ntBre

Thank you! This looks great overall. I Just had one suggestion about trimming down the number of test cases and one to share some code for the Truthiness checks.

I also think we should make this a preview (link is to an example preview function) change since the ecosystem check is showing a number of changes, including some now-unused noqa comments.

crates/ruff_linter/src/rules/flake8_blind_except/rules/blind_except.rs

crates/ruff_linter/resources/test/fixtures/flake8_blind_except/BLE.py

…info`` has been moved to the function and the number of tests has been reduced

ntBre

Thanks! A few more small comments.

crates/ruff_linter/src/rules/flake8_blind_except/mod.rs

crates/ruff_linter/src/rules/flake8_blind_except/rules/blind_except.rs

crates/ruff_linter/resources/test/fixtures/flake8_blind_except/BLE.py

…xcept.rs Co-authored-by: Brent Westbrook <36778786+ntBre@users.noreply.github.com>

ntBre

Thank you!

ntBre · 2026-01-14T21:13:58Z

(closing and re-opening to rerun the prek check)

lubaskinc0de added 5 commits December 18, 2025 13:46

feat(blind_except.rs): check if exception logged with any exc_info co…

119927e

…mpatible logging method

tests(BLE.py): add snapshot tests for debug logging

d0d99e5

tests(BLE.py): snapshot tests for logging.info, logging.warning and l…

6223149

…ogging.log

tests(BLE.py): finish blind-except tests

b878149

refactor(blind_except.rs) inline Truthiness expression

47bbc48

lubaskinc0de changed the title ~~[flake8-blind-except] Allowed exception logging with functions other than critical and error (BLE001)~~ [flake8-blind-except] Allowed exception logging with functions other than critical, error and exception (BLE001) Dec 18, 2025

chirizxc reviewed Dec 19, 2025

View reviewed changes

crates/ruff_linter/src/rules/flake8_blind_except/rules/blind_except.rs Outdated Show resolved Hide resolved

feat(): move is_logger_method_name function to helpers and write …

ce69b21

…test-cases for ``logging.warn`

chirizxc reviewed Dec 22, 2025

View reviewed changes

crates/ruff_linter/src/rules/flake8_blind_except/rules/blind_except.rs Outdated Show resolved Hide resolved

chirizxc reviewed Dec 22, 2025

View reviewed changes

crates/ruff_linter/src/rules/flake8_logging/rules/root_logger_call.rs Outdated Show resolved Hide resolved

lubaskinc0de added 3 commits December 24, 2025 22:32

refactor(): move is_logger_method_name function to ``flake8_loggi…

de6086c

…ng::helpers``

refactor(): move crate-import to bottom

bc480bb

refactor(): move crate import bottom

9e6036e

ntBre reviewed Dec 24, 2025

View reviewed changes

crates/ruff_linter/src/rules/flake8_blind_except/rules/blind_except.rs Outdated Show resolved Hide resolved

crates/ruff_linter/resources/test/fixtures/flake8_blind_except/BLE.py Show resolved Hide resolved

ntBre added rule Implementing or modifying a lint rule preview Related to preview mode features labels Dec 24, 2025

lubaskinc0de added 5 commits December 27, 2025 17:44

refactor(): the general functionality of checking the argument ``exc_…

7dc86bd

…info`` has been moved to the function and the number of tests has been reduced

feat(): hide fix under preview

a127720

tests(): add preview test snapshot

cc5d98b

tests(): accept snapshots

f185db0

lint(): fix typo

ea26f46

lubaskinc0de requested review from chirizxc and ntBre December 27, 2025 21:55

ntBre linked an issue Jan 1, 2026 that may be closed by this pull request

BLE001 (blind-except): false positive when logging via warning #21889

Closed

ntBre reviewed Jan 1, 2026

View reviewed changes

lubaskinc0de and others added 2 commits January 3, 2026 13:05

Update crates/ruff_linter/src/rules/flake8_blind_except/rules/blind_e…

5de5c6f

…xcept.rs Co-authored-by: Brent Westbrook <36778786+ntBre@users.noreply.github.com>

fix(): fixes by review

b4800d1

lubaskinc0de requested a review from ntBre January 3, 2026 10:55

Merge branch 'main' into feat/21889-ble001

7df58a0

ntBre approved these changes Jan 14, 2026

View reviewed changes

ntBre closed this Jan 14, 2026

ntBre reopened this Jan 14, 2026

ntBre changed the title ~~[flake8-blind-except] Allowed exception logging with functions other than critical, error and exception (BLE001)~~ [flake8-blind-except] Allow more logging methods (BLE001) Jan 14, 2026

ntBre enabled auto-merge (squash) January 14, 2026 21:15

ntBre merged commit 5d99ef9 into astral-sh:main Jan 14, 2026
81 checks passed

ntBre mentioned this pull request Jan 29, 2026

RUF100 false-positive for BLE001 #22941

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[`flake8-blind-except`] Allow more logging methods (`BLE001`)#22057

[`flake8-blind-except`] Allow more logging methods (`BLE001`)#22057
ntBre merged 17 commits intoastral-sh:mainfrom
lubaskinc0de:feat/21889-ble001

lubaskinc0de commented Dec 18, 2025 •

edited

Loading

Uh oh!

astral-sh-bot bot commented Dec 18, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ntBre left a comment

Uh oh!

Uh oh!

Uh oh!

ntBre left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ntBre left a comment

Uh oh!

ntBre commented Jan 14, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

lubaskinc0de commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test Plan

Uh oh!

astral-sh-bot bot commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

ruff-ecosystem results

Linter (stable)

Linter (preview)

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ntBre left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ntBre left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ntBre left a comment

Choose a reason for hiding this comment

Uh oh!

ntBre commented Jan 14, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

lubaskinc0de commented Dec 18, 2025 •

edited

Loading

astral-sh-bot bot commented Dec 18, 2025 •

edited

Loading

`ruff-ecosystem` results