Fix \r and \r\n handling in t- and f-string debug texts#18673
Merged
MichaReiser merged 1 commit intomainfrom Jun 15, 2025
Merged
Fix \r and \r\n handling in t- and f-string debug texts#18673MichaReiser merged 1 commit intomainfrom
\r and \r\n handling in t- and f-string debug texts#18673MichaReiser merged 1 commit intomainfrom
Conversation
Contributor
|
ntBre
approved these changes
Jun 14, 2025
Contributor
ntBre
left a comment
There was a problem hiding this comment.
Nice! This makes sense to me.
Member
Author
|
I was a bit confused why this would lead to duplicate lines but I think I understand it now:
Now we have two line breaks. The printer will now infer |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #18667
The
Printeronly supports\n. We, therefore, need to normalize the newlines in debug texts during formatting.Normalizing the newlines doesn't change the Python semantics because Python normalizes all newlines to
\nTest Plan
Added snapshot test