Config error only when flake8-import-conventions alias conflicts with isort.required-imports bound name#15918
Merged
dylwil3 merged 4 commits intoastral-sh:mainfrom Feb 4, 2025
Merged
Conversation
dylwil3
commented
Feb 3, 2025
Contributor
|
ntBre
approved these changes
Feb 4, 2025
Contributor
ntBre
left a comment
There was a problem hiding this comment.
Looks great, thank you for fixing this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously an error was emitted any time the configuration required both an import of a module and an alias for that module. However, required imports could themselves contain an alias, which may or may not agree with the required alias.
To wit: requiring
import pandas as pddoes not conflict with theflake8-import-conventions.aliasconfig{"pandas":"pd"}.This PR refines the check before throwing an error.
Closes #15911