[ruff] Stop parsing diagnostics from other sources for code action requests#15373
Merged
MichaReiser merged 1 commit intoastral-sh:mainfrom Jan 9, 2025
Merged
[ruff] Stop parsing diagnostics from other sources for code action requests#15373MichaReiser merged 1 commit intoastral-sh:mainfrom
ruff] Stop parsing diagnostics from other sources for code action requests#15373MichaReiser merged 1 commit intoastral-sh:mainfrom
Conversation
Contributor
|
MichaReiser
approved these changes
Jan 9, 2025
Member
MichaReiser
left a comment
There was a problem hiding this comment.
Nice. Interesting that the client sends all known Diagnostic but that sort of makes sense.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR stops
ruff serverattempting to parse diagnostic data for diagnostics from other language servers.The issue
When using
ruff serverwithtypos-lspinhelix, it is impossible to apply code actions suggested bytypos-lsp.The cause
During a
textDocument/codeActionrequest, the editor will sendDiagnostics toruff serveras part of thecodeActionContext- these may have been generated by other LSP servers.According to the spec, the
Diagnostic.datafield can contain any data. However,ruff serverattempts to parse all contextual diagnostics, and assumes thedatafield adheres to the data structure used byruff server.Since other language servers are free to use their own data structure, parsing the diagnostics fails causing an error, which ultimately causes the code action request to fail.
The fix
On code action requests,
ruff servershould only parse contextual diagnostics generated byruff server.