[airflow] Extend names moved from core to provider (AIR303)#15216
Merged
dhruvmanila merged 2 commits intoastral-sh:mainfrom Jan 2, 2025
Merged
[airflow] Extend names moved from core to provider (AIR303)#15216dhruvmanila merged 2 commits intoastral-sh:mainfrom
airflow] Extend names moved from core to provider (AIR303)#15216dhruvmanila merged 2 commits intoastral-sh:mainfrom
Conversation
* `airflow.kubernetes.kubernetes_helper_functions.add_pod_suffix` → `airflow.providers.cncf.kubernetes.kubernetes_helper_functions.add_pod_suffix` * `airflow.kubernetes.kubernetes_helper_functions.annotations_for_logging_task_metadata` → `airflow.providers.cncf.kubernetes.kubernetes_helper_functions.annotations_for_logging_task_metadata` * `airflow.kubernetes.kubernetes_helper_functions.annotations_to_key` → `airflow.providers.cncf.kubernetes.kubernetes_helper_functions.annotations_to_key` * `airflow.kubernetes.kubernetes_helper_functions.create_pod_id` → `airflow.providers.cncf.kubernetes.kubernetes_helper_functions.create_pod_id` * `airflow.kubernetes.kubernetes_helper_functions.get_logs_task_metadata` → `airflow.providers.cncf.kubernetes.kubernetes_helper_functions.get_logs_task_metadata` * `airflow.kubernetes.kubernetes_helper_functions.rand_str` → `airflow.providers.cncf.kubernetes.kubernetes_helper_functions.rand_str` * `airflow.kubernetes.pod.Port` → `kubernetes.client.models.V1ContainerPort` * `airflow.kubernetes.pod.Resources` → `kubernetes.client.models.V1ResourceRequirements` * `airflow.kubernetes.pod_launcher.PodLauncher` → `airflow.providers.cncf.kubernetes.pod_launcher.PodLauncher` * `airflow.kubernetes.pod_launcher.PodStatus` → `airflow.providers.cncf.kubernetes.pod_launcher.PodStatus` * `airflow.kubernetes.pod_launcher_deprecated.PodLauncher` → `airflow.providers.cncf.kubernetes.pod_launcher_deprecated.PodLauncher` * `airflow.kubernetes.pod_launcher_deprecated.PodStatus` → `airflow.providers.cncf.kubernetes.pod_launcher_deprecated.PodStatus` * `airflow.kubernetes.pod_launcher_deprecated.get_kube_client` → `airflow.providers.cncf.kubernetes.kube_client.get_kube_client` * `airflow.kubernetes.pod_launcher_deprecated.PodDefaults` → `airflow.providers.cncf.kubernetes.pod_generator_deprecated.PodDefaults` * `airflow.kubernetes.pod_runtime_info_env.PodRuntimeInfoEnv` → `kubernetes.client.models.V1EnvVar` * `airflow.kubernetes.volume.Volume` → `kubernetes.client.models.V1Volume` * `airflow.kubernetes.volume_mount.VolumeMount` → `kubernetes.client.models.V1VolumeMount` * `airflow.kubernetes.k8s_model.K8SModel` → `airflow.providers.cncf.kubernetes.k8s_model.K8SModel` * `airflow.kubernetes.k8s_model.append_to_pod` → `airflow.providers.cncf.kubernetes.k8s_model.append_to_pod` * `airflow.kubernetes.kube_client._disable_verify_ssl` → `airflow.kubernetes.airflow.providers.cncf.kubernetes.kube_client._disable_verify_ssl` * `airflow.kubernetes.kube_client._enable_tcp_keepalive` → `airflow.kubernetes.airflow.providers.cncf.kubernetes.kube_client._enable_tcp_keepalive` * `airflow.kubernetes.kube_client.get_kube_client` → `airflow.kubernetes.airflow.providers.cncf.kubernetes.kube_client.get_kube_client` * `airflow.kubernetes.pod_generator.datetime_to_label_safe_datestring` → `airflow.providers.cncf.kubernetes.pod_generator.datetime_to_label_safe_datestring` * `airflow.kubernetes.pod_generator.extend_object_field` → `airflow.kubernetes.airflow.providers.cncf.kubernetes.pod_generator.extend_object_field` * `airflow.kubernetes.pod_generator.label_safe_datestring_to_datetime` → `airflow.providers.cncf.kubernetes.pod_generator.label_safe_datestring_to_datetime` * `airflow.kubernetes.pod_generator.make_safe_label_value` → `airflow.providers.cncf.kubernetes.pod_generator.make_safe_label_value` * `airflow.kubernetes.pod_generator.merge_objects` → `airflow.providers.cncf.kubernetes.pod_generator.merge_objects` * `airflow.kubernetes.pod_generator.PodGenerator` → `airflow.providers.cncf.kubernetes.pod_generator.PodGenerator` * `airflow.kubernetes.pod_generator.PodGeneratorDeprecated` → `airflow.providers.cncf.kubernetes.pod_generator.PodGenerator` * `airflow.kubernetes.pod_generator.PodDefaults` → `airflow.providers.cncf.kubernetes.pod_generator_deprecated.PodDefaults` * `airflow.kubernetes.pod_generator.add_pod_suffix` → `airflow.providers.cncf.kubernetes.kubernetes_helper_functions.add_pod_suffix` * `airflow.kubernetes.pod_generator.rand_str` → `airflow.providers.cncf.kubernetes.kubernetes_helper_functions.rand_str` * `airflow.kubernetes.pod_generator_deprecated.make_safe_label_value` → `airflow.providers.cncf.kubernetes.pod_generator_deprecated.make_safe_label_value` * `airflow.kubernetes.pod_generator_deprecated.PodDefaults` → `airflow.providers.cncf.kubernetes.pod_generator_deprecated.PodDefaults` * `airflow.kubernetes.pod_generator_deprecated.PodGenerator` → `airflow.providers.cncf.kubernetes.pod_generator_deprecated.PodGenerator` * `airflow.kubernetes.secret.Secret` → `airflow.providers.cncf.kubernetes.secret.Secret` * `airflow.kubernetes.secret.K8SModel` → `airflow.providers.cncf.kubernetes.k8s_model.K8SModel`
2 tasks
Contributor
|
Contributor
Author
|
I think this is the last PR that contains this many rules |
dhruvmanila
approved these changes
Jan 2, 2025
Member
dhruvmanila
left a comment
There was a problem hiding this comment.
Thank you! I think we should do a similar refactor as I did in 86bdc2e to simplify the match expression. I can do that as a follow-up, shouldn't be more than a couple of minutes.
airflow] Extend names moved from core to provider (AIR303)
Contributor
Author
|
Would love to try it! Will create a PR later today |
Contributor
Author
|
just created #15220 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Many core Airflow features have been deprecated and moved to Airflow Providers since users might need to install an additional package (e.g.,
apache-airflow-provider-fab==1.0.0); a separate rule (AIR303) is created for this.airflow.kubernetes.kubernetes_helper_functions.add_pod_suffix→airflow.providers.cncf.kubernetes.kubernetes_helper_functions.add_pod_suffixairflow.kubernetes.kubernetes_helper_functions.annotations_for_logging_task_metadata→airflow.providers.cncf.kubernetes.kubernetes_helper_functions.annotations_for_logging_task_metadataairflow.kubernetes.kubernetes_helper_functions.annotations_to_key→airflow.providers.cncf.kubernetes.kubernetes_helper_functions.annotations_to_keyairflow.kubernetes.kubernetes_helper_functions.create_pod_id→airflow.providers.cncf.kubernetes.kubernetes_helper_functions.create_pod_idairflow.kubernetes.kubernetes_helper_functions.get_logs_task_metadata→airflow.providers.cncf.kubernetes.kubernetes_helper_functions.get_logs_task_metadataairflow.kubernetes.kubernetes_helper_functions.rand_str→airflow.providers.cncf.kubernetes.kubernetes_helper_functions.rand_strairflow.kubernetes.pod.Port→kubernetes.client.models.V1ContainerPortairflow.kubernetes.pod.Resources→kubernetes.client.models.V1ResourceRequirementsairflow.kubernetes.pod_launcher.PodLauncher→airflow.providers.cncf.kubernetes.pod_launcher.PodLauncherairflow.kubernetes.pod_launcher.PodStatus→airflow.providers.cncf.kubernetes.pod_launcher.PodStatusairflow.kubernetes.pod_launcher_deprecated.PodLauncher→airflow.providers.cncf.kubernetes.pod_launcher_deprecated.PodLauncherairflow.kubernetes.pod_launcher_deprecated.PodStatus→airflow.providers.cncf.kubernetes.pod_launcher_deprecated.PodStatusairflow.kubernetes.pod_launcher_deprecated.get_kube_client→airflow.providers.cncf.kubernetes.kube_client.get_kube_clientairflow.kubernetes.pod_launcher_deprecated.PodDefaults→airflow.providers.cncf.kubernetes.pod_generator_deprecated.PodDefaultsairflow.kubernetes.pod_runtime_info_env.PodRuntimeInfoEnv→kubernetes.client.models.V1EnvVarairflow.kubernetes.volume.Volume→kubernetes.client.models.V1Volumeairflow.kubernetes.volume_mount.VolumeMount→kubernetes.client.models.V1VolumeMountairflow.kubernetes.k8s_model.K8SModel→airflow.providers.cncf.kubernetes.k8s_model.K8SModelairflow.kubernetes.k8s_model.append_to_pod→airflow.providers.cncf.kubernetes.k8s_model.append_to_podairflow.kubernetes.kube_client._disable_verify_ssl→airflow.kubernetes.airflow.providers.cncf.kubernetes.kube_client._disable_verify_sslairflow.kubernetes.kube_client._enable_tcp_keepalive→airflow.kubernetes.airflow.providers.cncf.kubernetes.kube_client._enable_tcp_keepaliveairflow.kubernetes.kube_client.get_kube_client→airflow.kubernetes.airflow.providers.cncf.kubernetes.kube_client.get_kube_clientairflow.kubernetes.pod_generator.datetime_to_label_safe_datestring→airflow.providers.cncf.kubernetes.pod_generator.datetime_to_label_safe_datestringairflow.kubernetes.pod_generator.extend_object_field→airflow.kubernetes.airflow.providers.cncf.kubernetes.pod_generator.extend_object_fieldairflow.kubernetes.pod_generator.label_safe_datestring_to_datetime→airflow.providers.cncf.kubernetes.pod_generator.label_safe_datestring_to_datetimeairflow.kubernetes.pod_generator.make_safe_label_value→airflow.providers.cncf.kubernetes.pod_generator.make_safe_label_valueairflow.kubernetes.pod_generator.merge_objects→airflow.providers.cncf.kubernetes.pod_generator.merge_objectsairflow.kubernetes.pod_generator.PodGenerator→airflow.providers.cncf.kubernetes.pod_generator.PodGeneratorairflow.kubernetes.pod_generator.PodGeneratorDeprecated→airflow.providers.cncf.kubernetes.pod_generator.PodGeneratorairflow.kubernetes.pod_generator.PodDefaults→airflow.providers.cncf.kubernetes.pod_generator_deprecated.PodDefaultsairflow.kubernetes.pod_generator.add_pod_suffix→airflow.providers.cncf.kubernetes.kubernetes_helper_functions.add_pod_suffixairflow.kubernetes.pod_generator.rand_str→airflow.providers.cncf.kubernetes.kubernetes_helper_functions.rand_strairflow.kubernetes.pod_generator_deprecated.make_safe_label_value→airflow.providers.cncf.kubernetes.pod_generator_deprecated.make_safe_label_valueairflow.kubernetes.pod_generator_deprecated.PodDefaults→airflow.providers.cncf.kubernetes.pod_generator_deprecated.PodDefaultsairflow.kubernetes.pod_generator_deprecated.PodGenerator→airflow.providers.cncf.kubernetes.pod_generator_deprecated.PodGeneratorairflow.kubernetes.secret.Secret→airflow.providers.cncf.kubernetes.secret.Secretairflow.kubernetes.secret.K8SModel→airflow.providers.cncf.kubernetes.k8s_model.K8SModelTest Plan
A test fixture has been included for the rule.