[ruff] Adds an allowlist for unsafe-markup-use (RUF035)#15076
Merged
dhruvmanila merged 5 commits intoastral-sh:mainfrom Dec 20, 2024
Merged
[ruff] Adds an allowlist for unsafe-markup-use (RUF035)#15076dhruvmanila merged 5 commits intoastral-sh:mainfrom
ruff] Adds an allowlist for unsafe-markup-use (RUF035)#15076dhruvmanila merged 5 commits intoastral-sh:mainfrom
Conversation
Daverball
commented
Dec 20, 2024
Comment on lines
+7
to
+9
| # indirect assignments are currently not supported | ||
| cleaned = clean(content) | ||
| Markup(cleaned) # RUF035 |
Contributor
Author
There was a problem hiding this comment.
I considered making this work. But then we should probably also make the same thing work with string/bytes literals. At which point I would have to change some of the examples, so they still make sense. So I held off for now.
Member
There was a problem hiding this comment.
I think it's fine for now to limit this to only direct calls.
Contributor
|
dhruvmanila
reviewed
Dec 20, 2024
ruff] Adds a whitelist for unsafe-markup-use.ruff] Adds an allowlist for unsafe-markup-use.
dhruvmanila
reviewed
Dec 20, 2024
dhruvmanila
approved these changes
Dec 20, 2024
ruff] Adds an allowlist for unsafe-markup-use.ruff] Adds an allowlist for unsafe-markup-use (RUF035)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #14523
Summary
Adds a whitelist of calls allowed to be used within a
markupsafe.Markupcall.Test Plan
cargo nextest run