[ruff] Avoid false positives for RUF027 for typing context bindings.#15037
Merged
MichaReiser merged 3 commits intoastral-sh:mainfrom Dec 18, 2024
Merged
[ruff] Avoid false positives for RUF027 for typing context bindings.#15037MichaReiser merged 3 commits intoastral-sh:mainfrom
ruff] Avoid false positives for RUF027 for typing context bindings.#15037MichaReiser merged 3 commits intoastral-sh:mainfrom
Conversation
Contributor
|
MichaReiser
approved these changes
Dec 17, 2024
crates/ruff_linter/src/rules/ruff/rules/missing_fstring_syntax.rs
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #14000
Summary
For typing context bindings we know that they won't be available at runtime. We shouldn't recommend a fix, that will result in name errors at runtime.
Test Plan
cargo nextest run