[refurb] Guard hashlib imports and mark hashlib-digest-hex fix as safe (FURB181)#14694
Merged
charliermarsh merged 1 commit intoastral-sh:mainfrom Dec 2, 2024
Merged
Conversation
Contributor
|
charliermarsh
approved these changes
Dec 2, 2024
Member
charliermarsh
left a comment
There was a problem hiding this comment.
This makes sense, thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hashlibandcryptimports have been seen forFURB181andS324FURB181as safe: I think it was accidentally marked as unsafe in the first place. The rule does not support user-defined classes as the "fix safety" section suggests.hashlib._Hash, as it's not part of thehashlibmodule.Test Plan
Updated the test snapshots