[ruff] Detect redirected-noqa in file-level comments (RUF101)#14635
Merged
MichaReiser merged 11 commits intoastral-sh:mainfrom Nov 27, 2024
Merged
[ruff] Detect redirected-noqa in file-level comments (RUF101)#14635MichaReiser merged 11 commits intoastral-sh:mainfrom
ruff] Detect redirected-noqa in file-level comments (RUF101)#14635MichaReiser merged 11 commits intoastral-sh:mainfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #14531, where ruff was not reporting diagnostics on file-level
# ruff: noqacomments with redirected rule codes.The main change here is making
ParsedFileExemptioncloser in structure toDirective, with a sequence ofCodeswithTextRanges instead of just&strfor diagnostic reporting.Test Plan
The changes were tested against the example code from #14531 to make sure the diagnostic is now emitted.