[flake8-type-checking] Fixes quote_type_expression#14634
Merged
MichaReiser merged 4 commits intoastral-sh:mainfrom Nov 27, 2024
Merged
[flake8-type-checking] Fixes quote_type_expression#14634MichaReiser merged 4 commits intoastral-sh:mainfrom
flake8-type-checking] Fixes quote_type_expression#14634MichaReiser merged 4 commits intoastral-sh:mainfrom
Conversation
Contributor
|
Contributor
Author
|
@MichaReiser This is looking pretty good. Do you want to handle the changes to |
Member
Glad to hear that! I would prefer a separate PR, unless it requires extra work from your side |
flake8-type-checking] Fixes quote_type_expressionflake8-type-checking] Fixes quote_type_expression
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes: #14614
Fixes: #14538
Fixes: #14554
Summary
This achieves a more feature complete version of wrapping annotations in quotes while removing nested forward references and handling nested quotes correctly.
It's not currently making use of the parsed annotations cache. I tried to pass around
CheckerandParsedAnnotationsCache, either approach caused a cascade of borrow checker errors related to lifetimes I wasn't able to resolve.This is not yet trying to force the outermost quotes of the quoted type expression to match our preference, so there are some scenarios where
Generatorwill pick the opposite style.Test Plan
cargo nextest run