Ignore more rules for stub files#14541
Merged
dylwil3 merged 7 commits intoastral-sh:mainfrom Nov 23, 2024
Merged
Conversation
MichaReiser
approved these changes
Nov 22, 2024
Contributor
|
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| FBT001 | 15 | 0 | 15 | 0 | 0 |
| PLR0913 | 4 | 0 | 4 | 0 | 0 |
Linter (preview)
ℹ️ ecosystem check detected linter changes. (+0 -23 violations, +0 -0 fixes in 2 projects; 52 projects unchanged)
apache/airflow (+0 -4 violations, +0 -0 fixes)
ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview --select ALL
- airflow/decorators/__init__.pyi:185:9: PLR0913 Too many arguments in function definition (9 > 5) - airflow/decorators/__init__.pyi:379:9: PLR0913 Too many arguments in function definition (47 > 5) - airflow/decorators/__init__.pyi:537:9: PLR0913 Too many arguments in function definition (59 > 5) - airflow/decorators/__init__.pyi:67:1: PLR0904 Too many public methods (26 > 20)
bokeh/bokeh (+0 -19 violations, +0 -0 fixes)
ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview --select ALL
- src/typings/IPython/core/history.pyi:5:38: FBT001 Boolean-typed positional argument in function definition - src/typings/IPython/core/history.pyi:6:9: FBT001 Boolean-typed positional argument in function definition - src/typings/IPython/core/history.pyi:8:38: FBT001 Boolean-typed positional argument in function definition - src/typings/IPython/core/history.pyi:9:9: FBT001 Boolean-typed positional argument in function definition - src/typings/bs4.pyi:21:9: FBT001 Boolean-typed positional argument in function definition - src/typings/json5.pyi:14:5: FBT001 Boolean-typed positional argument in function definition - src/typings/json5.pyi:15:5: FBT001 Boolean-typed positional argument in function definition - src/typings/json5.pyi:16:5: FBT001 Boolean-typed positional argument in function definition - src/typings/json5.pyi:17:5: FBT001 Boolean-typed positional argument in function definition - src/typings/json5.pyi:4:5: PLR0913 Too many arguments in function definition (13 > 5) - src/typings/json5.pyi:4:5: PLR0917 Too many positional arguments (13/5) - src/typings/json5.pyi:6:5: FBT001 Boolean-typed positional argument in function definition - src/typings/json5.pyi:7:5: FBT001 Boolean-typed positional argument in function definition ... 6 additional changes omitted for rule FBT001 - src/typings/selenium/webdriver/remote/webelement.pyi:21:1: PLR0904 Too many public methods (22 > 20)
Changes by rule (4 rules affected)
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| FBT001 | 16 | 0 | 16 | 0 | 0 |
| PLR0913 | 4 | 0 | 4 | 0 | 0 |
| PLR0904 | 2 | 0 | 2 | 0 | 0 |
| PLR0917 | 1 | 0 | 1 | 0 | 0 |
Avasam
reviewed
Nov 22, 2024
crates/ruff_linter/src/rules/flake8_boolean_trap/rules/boolean_positional_value_in_call.rs
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR causes the following rules to ignore stub files, on the grounds that it is not under the author's control to appease these lints:
PLR0904https://docs.astral.sh/ruff/rules/too-many-public-methods/PLR0913https://docs.astral.sh/ruff/rules/too-many-arguments/PLR0917https://docs.astral.sh/ruff/rules/too-many-positional-arguments/PLW3201https://docs.astral.sh/ruff/rules/bad-dunder-method-name/SLOThttps://docs.astral.sh/ruff/rules/#flake8-slots-slotFBThttps://docs.astral.sh/ruff/rules/#flake8-boolean-trap-fbt (except for FBT003 since that involves a function call.)Progress towards #14535