[flake8-pyi] Implement redundant-none-literal (PYI061)#14316
Conversation
|
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| PYI061 | 14 | 14 | 0 | 0 | 0 |
|
Hi @sbrugman Thanks for another PR. It would help me review your PRs and avoid unnecessary work if you could fill out the Test plan. E.g. did you review the ecosystem changes already? If so, then I don't have to do so :) |
|
Is there some previous issue where we discussed this rule? I'm asking because the rule itself would be a better fit for |
|
@MichaReiser I've updated the test plan above, will do so for the other issues as well. You're right that these rules fit better in another category, but since there is no upstream rule I've placed them here. I'm ok moving the rules if preferred. |
|
It looks like this could actually be in flake8-pyi: |
ruff] Implement redundant-none-literal (RUF037)flake8-pyi] Implement redundant-none-literal (PYI061)
9f4cad0 to
581f0da
Compare
MichaReiser
left a comment
There was a problem hiding this comment.
LGTM, @AlexWaygood could you sign off the rule :)
| if let Some(ref fix) = fix { | ||
| diagnostic.set_fix(fix.clone()); | ||
| } |
There was a problem hiding this comment.
I'm surprised that setting the same fix works 😆
AlexWaygood
left a comment
There was a problem hiding this comment.
Thanks! A couple of nitpicks, but looks great overall
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
AlexWaygood
left a comment
There was a problem hiding this comment.
Thank you! Looks great, just a couple of nits about the test remaining
…sh#14316) ## Summary `Literal[None]` can be simplified into `None` in type annotations. Surprising to see that this is not that rare: - https://github.com/langchain-ai/langchain/blob/master/libs/langchain/langchain/chat_models/base.py#L54 - https://github.com/sqlalchemy/sqlalchemy/blob/main/lib/sqlalchemy/sql/annotation.py#L69 - https://github.com/jax-ml/jax/blob/main/jax/numpy/__init__.pyi#L961 - https://github.com/huggingface/huggingface_hub/blob/main/src/huggingface_hub/inference/_common.py#L179 ## Test Plan `cargo test` Reviewed all ecosystem results, and they are true positives. --------- Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com> Co-authored-by: Charlie Marsh <charlie.r.marsh@gmail.com>
Summary
Literal[None]can be simplified intoNonein type annotations.Surprising to see that this is not that rare:
Test Plan
cargo testReviewed all ecosystem results, and they are true positives.