Detect empty implicit namespace packages#14236
Merged
charliermarsh merged 2 commits intomainfrom Nov 10, 2024
Merged
Conversation
9a2685d to
ea43a67
Compare
Contributor
|
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| INP001 | 2 | 2 | 0 | 0 | 0 |
8638bfd to
4fe30cf
Compare
4fe30cf to
0fb0ff1
Compare
MichaReiser
reviewed
Nov 12, 2024
Member
There was a problem hiding this comment.
Is it intentional that this file is commited?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The implicit namespace package rule currently fails to detect cases like the following:
The problem is that we detect a root at
foo, and then an independent root atbaz. We would detect thatbaris an implicit namespace package, but it doesn't contain any files! So we never check it, and have no place to raise the diagnostic.This PR adds detection for these kinds of nested packages, and augments the
INPrule to flag the__init__.pyfile above with a specialized message. As a side effect, I've introduced a dedicatedPackageRootstruct which we can pass around in lieu of Yet AnotherPath.For now, I'm only enabling this in preview (and the approach doesn't affect any other rules). It's a bug fix, but it may end up expanding the rule.
Closes #13519.