Skip to content

[refurb] Use UserString instead of non-existent UserStr#14209

Merged
charliermarsh merged 1 commit intoastral-sh:mainfrom
nijel:userstring
Nov 9, 2024
Merged

[refurb] Use UserString instead of non-existent UserStr#14209
charliermarsh merged 1 commit intoastral-sh:mainfrom
nijel:userstring

Conversation

@nijel
Copy link
Copy Markdown
Contributor

@nijel nijel commented Nov 8, 2024

Summary

The class name is UserString, not a UserStr, see https://docs.python.org/3.9/library/collections.html#collections.UserString

Test Plan

@nijel
Fix FURB189 replacing str to UserString
eef5066 
The class name is UserString, not a UserStr.
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 8, 2024

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

ℹ️ ecosystem check detected linter changes. (+5 -5 violations, +0 -0 fixes in 4 projects; 50 projects unchanged)

apache/airflow (+2 -2 violations, +0 -0 fixes) 

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview --select ALL

- kubernetes_tests/test_base.py:45:26: FURB189 Subclassing `str` can be error prone, use `collections.UserStr` instead
+ kubernetes_tests/test_base.py:45:26: FURB189 Subclassing `str` can be error prone, use `collections.UserString` instead
- tests/utils/log/test_secrets_masker.py:317:54: FURB189 Subclassing `str` can be error prone, use `collections.UserStr` instead
+ tests/utils/log/test_secrets_masker.py:317:54: FURB189 Subclassing `str` can be error prone, use `collections.UserString` instead

langchain-ai/langchain (+1 -1 violations, +0 -0 fixes) 

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview

- libs/core/tests/unit_tests/stubs.py:7:14: FURB189 Subclassing `str` can be error prone, use `collections.UserStr` instead
+ libs/core/tests/unit_tests/stubs.py:7:14: FURB189 Subclassing `str` can be error prone, use `collections.UserString` instead

scikit-build/scikit-build-core (+1 -1 violations, +0 -0 fixes) 

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview

- src/scikit_build_core/settings/skbuild_model.py:31:27: FURB189 Subclassing `str` can be error prone, use `collections.UserStr` instead
+ src/scikit_build_core/settings/skbuild_model.py:31:27: FURB189 Subclassing `str` can be error prone, use `collections.UserString` instead

indico/indico (+1 -1 violations, +0 -0 fixes) 

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview

- indico/legacy/pdfinterface/latex.py:169:16: FURB189 Subclassing `str` can be error prone, use `collections.UserStr` instead
+ indico/legacy/pdfinterface/latex.py:169:16: FURB189 Subclassing `str` can be error prone, use `collections.UserString` instead

Changes by rule (1 rules affected)

code total + violation - violation + fix - fix
FURB189 10 5 5 0 0

@sbrugman
Copy link
Copy Markdown
Contributor

sbrugman commented Nov 8, 2024

Thanks!

charliermarsh
charliermarsh approved these changes Nov 9, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@charliermarsh charliermarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, whoops!

@charliermarsh charliermarsh added the bug Something isn't working label Nov 9, 2024
@charliermarsh charliermarsh changed the title Fix FURB189 replacing str to UserString [refurb] Use UserString instead of non-existent UserStr Nov 9, 2024
@charliermarsh charliermarsh merged commit b19f388 into astral-sh:main Nov 9, 2024
@nijel nijel deleted the userstring branch November 9, 2024 05:48
@sbrugman sbrugman mentioned this pull request Nov 11, 2024
Closed
@BrewTestBot BrewTestBot mentioned this pull request Nov 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@charliermarsh charliermarsh charliermarsh approved these changes

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nijel @sbrugman @charliermarsh