FBT001: exclude boolean operators#14203
Conversation
|
Should we be ignoring all dunders? |
|
We have an |
a2411d6 to
f424f00
Compare
|
|
@charliermarsh I updated using However, I am not sure if this is the best approach. For one, there is no official list of dunder methods from python's side, and what is considered a known dunder method can change from one version to the next. Maybe a simpler approach would be to just exclude dunder methods in general? This would be easier to document/teach as well. |
|
The |
|
I think "all dunder methods except init and new" should be easy to maintain and explain. |
charliermarsh
left a comment
There was a problem hiding this comment.
Thanks -- this looks reasonable to me.
Fixes #14202
Summary
Exclude rule FBT001 for boolean operators.
Test Plan
Updated existing
FBT.pytest.