[eradicate] Better detection of IntelliJ language injection comments (ERA001)#14094
[eradicate] Better detection of IntelliJ language injection comments (ERA001)#14094AlexWaygood merged 11 commits intoastral-sh:mainfrom
eradicate] Better detection of IntelliJ language injection comments (ERA001)#14094Conversation
|
By the way, do we want that giant regex to be case-insensitive? |
|
There was a problem hiding this comment.
Could you help me review this more efficiently by listing yoour changes so that I don't have to diff the Regex?
For case-sensitivity: I think we should use case-sensitive for the suppression comments that are case-sensitive and allow case-insensitivity for the ones that are not.
I also think we should gate this change behind preview mode unless all changes relax the rule's strictness.
|
Here's a comparison table:
As for
|
MichaReiser
left a comment
There was a problem hiding this comment.
Thanks for the table. That made reviewing so much easier.
This looks good to me. The main open question is if the change should be gated behind preview. I'm leaning towards no, considering that there are no changes in the ecosystem check. @AlexWaygood are you okay with this?
AlexWaygood
left a comment
There was a problem hiding this comment.
I'm fine with this. It feels like a bugfix to me and, as you say, the ecosystem report indicates that it shouldn't be that disruptive.
eradicate] Better detection of IntelliJ language injection comments (ERA001)
Summary
Enhances #14069.
Test Plan
A few tests are added to cover edge cases.