Skip to content

Improve some rule messages and docs#14068

Merged
charliermarsh merged 1 commit intomainfrom
charlie/d
Nov 3, 2024
Merged

Improve some rule messages and docs#14068
charliermarsh merged 1 commit intomainfrom
charlie/d

Conversation

@charliermarsh
Copy link
Member

@charliermarsh charliermarsh commented Nov 3, 2024

No description provided.

@charliermarsh charliermarsh added the docstring Related to docstring linting or formatting label Nov 3, 2024
@charliermarsh charliermarsh marked this pull request as ready for review November 3, 2024 19:21
@charliermarsh charliermarsh added documentation Improvements or additions to documentation and removed docstring Related to docstring linting or formatting labels Nov 3, 2024
@charliermarsh charliermarsh enabled auto-merge (squash) November 3, 2024 19:24
@charliermarsh charliermarsh merged commit 2b0cdd2 into main Nov 3, 2024
@charliermarsh charliermarsh deleted the charlie/d branch November 3, 2024 19:25
@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2024

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

ℹ️ ecosystem check detected linter changes. (+111 -111 violations, +0 -0 fixes in 7 projects; 47 projects unchanged)

DisnakeDev/disnake (+3 -3 violations, +0 -0 fixes) 

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview

+ disnake/ui/modal.py:236:22: RUF031 [*] Avoid parentheses for tuples in subscripts
- disnake/ui/modal.py:236:22: RUF031 [*] Avoid parentheses for tuples in subscripts.
+ disnake/ui/view.py:425:35: RUF031 [*] Avoid parentheses for tuples in subscripts
- disnake/ui/view.py:425:35: RUF031 [*] Avoid parentheses for tuples in subscripts.
+ disnake/ui/view.py:530:29: RUF031 [*] Avoid parentheses for tuples in subscripts
- disnake/ui/view.py:530:29: RUF031 [*] Avoid parentheses for tuples in subscripts.

RasaHQ/rasa (+1 -1 violations, +0 -0 fixes) 

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview

+ rasa/nlu/featurizers/sparse_featurizer/lexical_syntactic_featurizer.py:345:25: RUF031 [*] Avoid parentheses for tuples in subscripts
- rasa/nlu/featurizers/sparse_featurizer/lexical_syntactic_featurizer.py:345:25: RUF031 [*] Avoid parentheses for tuples in subscripts.

apache/airflow (+84 -84 violations, +0 -0 fixes) 

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview --select ALL

+ airflow/configuration.py:651:42: RUF031 [*] Avoid parentheses for tuples in subscripts
- airflow/configuration.py:651:42: RUF031 [*] Avoid parentheses for tuples in subscripts.
+ airflow/configuration.py:679:34: RUF031 [*] Avoid parentheses for tuples in subscripts
- airflow/configuration.py:679:34: RUF031 [*] Avoid parentheses for tuples in subscripts.
+ airflow/configuration.py:714:34: RUF031 [*] Avoid parentheses for tuples in subscripts
- airflow/configuration.py:714:34: RUF031 [*] Avoid parentheses for tuples in subscripts.
+ airflow/configuration.py:916:69: RUF031 [*] Avoid parentheses for tuples in subscripts
- airflow/configuration.py:916:69: RUF031 [*] Avoid parentheses for tuples in subscripts.
+ airflow/jobs/scheduler_job_runner.py:127:39: RUF031 [*] Avoid parentheses for tuples in subscripts
- airflow/jobs/scheduler_job_runner.py:127:39: RUF031 [*] Avoid parentheses for tuples in subscripts.
+ airflow/jobs/scheduler_job_runner.py:128:46: RUF031 [*] Avoid parentheses for tuples in subscripts
- airflow/jobs/scheduler_job_runner.py:128:46: RUF031 [*] Avoid parentheses for tuples in subscripts.
+ airflow/jobs/scheduler_job_runner.py:1600:47: RUF031 [*] Avoid parentheses for tuples in subscripts
- airflow/jobs/scheduler_job_runner.py:1600:47: RUF031 [*] Avoid parentheses for tuples in subscripts.
+ airflow/jobs/scheduler_job_runner.py:1634:33: RUF031 [*] Avoid parentheses for tuples in subscripts
- airflow/jobs/scheduler_job_runner.py:1634:33: RUF031 [*] Avoid parentheses for tuples in subscripts.
+ airflow/jobs/scheduler_job_runner.py:506:29: RUF031 [*] Avoid parentheses for tuples in subscripts
- airflow/jobs/scheduler_job_runner.py:506:29: RUF031 [*] Avoid parentheses for tuples in subscripts.
+ airflow/jobs/scheduler_job_runner.py:526:29: RUF031 [*] Avoid parentheses for tuples in subscripts
- airflow/jobs/scheduler_job_runner.py:526:29: RUF031 [*] Avoid parentheses for tuples in subscripts.
+ airflow/jobs/scheduler_job_runner.py:566:54: RUF031 [*] Avoid parentheses for tuples in subscripts
- airflow/jobs/scheduler_job_runner.py:566:54: RUF031 [*] Avoid parentheses for tuples in subscripts.
+ airflow/jobs/scheduler_job_runner.py:568:21: RUF031 [*] Avoid parentheses for tuples in subscripts
- airflow/jobs/scheduler_job_runner.py:568:21: RUF031 [*] Avoid parentheses for tuples in subscripts.
+ airflow/models/taskinstance.py:2915:39: RUF031 [*] Avoid parentheses for tuples in subscripts
- airflow/models/taskinstance.py:2915:39: RUF031 [*] Avoid parentheses for tuples in subscripts.
+ airflow/models/taskinstance.py:3594:28: RUF031 [*] Avoid parentheses for tuples in subscripts
- airflow/models/taskinstance.py:3594:28: RUF031 [*] Avoid parentheses for tuples in subscripts.
+ airflow/models/taskinstance.py:3595:30: RUF031 [*] Avoid parentheses for tuples in subscripts
- airflow/models/taskinstance.py:3595:30: RUF031 [*] Avoid parentheses for tuples in subscripts.
+ airflow/models/taskinstance.py:3601:49: RUF031 [*] Avoid parentheses for tuples in subscripts
- airflow/models/taskinstance.py:3601:49: RUF031 [*] Avoid parentheses for tuples in subscripts.
+ airflow/models/taskinstance.py:3602:53: RUF031 [*] Avoid parentheses for tuples in subscripts
- airflow/models/taskinstance.py:3602:53: RUF031 [*] Avoid parentheses for tuples in subscripts.
+ helm_tests/other/test_redis.py:61:41: RUF031 [*] Avoid parentheses for tuples in subscripts
- helm_tests/other/test_redis.py:61:41: RUF031 [*] Avoid parentheses for tuples in subscripts.
+ providers/src/airflow/providers/apache/hive/operators/hive_stats.py:101:17: RUF031 [*] Avoid parentheses for tuples in subscripts
... 131 additional changes omitted for project

apache/superset (+6 -6 violations, +0 -0 fixes) 

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview --select ALL

+ scripts/permissions_cleanup.py:32:19: RUF031 [*] Avoid parentheses for tuples in subscripts
- scripts/permissions_cleanup.py:32:19: RUF031 [*] Avoid parentheses for tuples in subscripts.
+ superset/models/dashboard.py:272:34: RUF031 [*] Avoid parentheses for tuples in subscripts
- superset/models/dashboard.py:272:34: RUF031 [*] Avoid parentheses for tuples in subscripts.
+ superset/utils/decorators.py:158:9: RUF034 Useless `if`-`else` condition
- superset/utils/decorators.py:158:9: RUF034 Useless if-else condition
+ superset/viz.py:1447:20: RUF031 [*] Avoid parentheses for tuples in subscripts
- superset/viz.py:1447:20: RUF031 [*] Avoid parentheses for tuples in subscripts.
... 5 additional changes omitted for rule RUF031
... 4 additional changes omitted for project

bokeh/bokeh (+4 -4 violations, +0 -0 fixes) 

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview --select ALL

+ examples/topics/graph/node_and_edge_attributes.py:21:16: RUF031 [*] Avoid parentheses for tuples in subscripts
- examples/topics/graph/node_and_edge_attributes.py:21:16: RUF031 [*] Avoid parentheses for tuples in subscripts.
+ src/bokeh/sampledata/unemployment.py:82:18: RUF031 [*] Avoid parentheses for tuples in subscripts
- src/bokeh/sampledata/unemployment.py:82:18: RUF031 [*] Avoid parentheses for tuples in subscripts.
+ src/bokeh/sampledata/us_counties.py:114:18: RUF031 [*] Avoid parentheses for tuples in subscripts
- src/bokeh/sampledata/us_counties.py:114:18: RUF031 [*] Avoid parentheses for tuples in subscripts.
+ tests/unit/bokeh/colors/test_util__colors.py:141:24: RUF031 [*] Avoid parentheses for tuples in subscripts
- tests/unit/bokeh/colors/test_util__colors.py:141:24: RUF031 [*] Avoid parentheses for tuples in subscripts.

pandas-dev/pandas (+1 -1 violations, +0 -0 fixes) 

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview

+ pandas/tests/io/formats/style/test_style.py:934:26: RUF034 Useless `if`-`else` condition
- pandas/tests/io/formats/style/test_style.py:934:26: RUF034 Useless if-else condition

zulip/zulip (+12 -12 violations, +0 -0 fixes) 

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview --select ALL

+ analytics/lib/counts.py:541:28: RUF031 [*] Avoid parentheses for tuples in subscripts
- analytics/lib/counts.py:541:28: RUF031 [*] Avoid parentheses for tuples in subscripts.
+ zerver/actions/message_edit.py:968:17: RUF031 [*] Avoid parentheses for tuples in subscripts
- zerver/actions/message_edit.py:968:17: RUF031 [*] Avoid parentheses for tuples in subscripts.
+ zerver/lib/email_notifications.py:646:32: RUF031 [*] Avoid parentheses for tuples in subscripts
- zerver/lib/email_notifications.py:646:32: RUF031 [*] Avoid parentheses for tuples in subscripts.
+ zerver/lib/email_notifications.py:648:32: RUF031 [*] Avoid parentheses for tuples in subscripts
- zerver/lib/email_notifications.py:648:32: RUF031 [*] Avoid parentheses for tuples in subscripts.
+ zerver/lib/mention.py:133:33: RUF031 [*] Avoid parentheses for tuples in subscripts
- zerver/lib/mention.py:133:33: RUF031 [*] Avoid parentheses for tuples in subscripts.
... 14 additional changes omitted for project

Changes by rule (2 rules affected)

code total + violation - violation + fix - fix
RUF031 218 109 109 0 0
RUF034 4 2 2 0 0

@dhruvmanila dhruvmanila added the preview Related to preview mode features label Nov 4, 2024
@dhruvmanila
Copy link
Member

dhruvmanila commented Nov 4, 2024

I've added the preview Related to preview mode features label as all affected rules are in preview (per ecosystem comment).

@BrewTestBot BrewTestBot mentioned this pull request Nov 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation preview Related to preview mode features

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@charliermarsh @dhruvmanila