[`flake8-pyi`] - include all python file types for `PYI006` and `PYI066` by diceroll123 · Pull Request #14059 · astral-sh/ruff

diceroll123 · 2024-11-02T23:25:51Z

Summary

Allows bad-version-info-order and bad-version-info-comparison to work in file types besides stubs

Closes #13836

Test Plan

cargo test

I really only just moved code around and updated snapshots

github-actions · 2024-11-02T23:39:37Z

`ruff-ecosystem` results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

ℹ️ ecosystem check detected linter changes. (+42 -0 violations, +0 -0 fixes in 6 projects; 48 projects unchanged)

apache/airflow (+4 -0 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview --select ALL

+ providers/src/airflow/providers/cloudant/hooks/cloudant.py:25:4: PYI066 Use `>=` when using `if`-`else` with `sys.version_info` comparisons
+ providers/tests/cloudant/hooks/test_cloudant.py:30:4: PYI066 Use `>=` when using `if`-`else` with `sys.version_info` comparisons
+ providers/tests/google/cloud/utils/test_mlengine_prediction_summary.py:27:4: PYI066 Use `>=` when using `if`-`else` with `sys.version_info` comparisons
+ tests/plugins/test_plugins_manager.py:65:12: PYI066 Use `>=` when using `if`-`else` with `sys.version_info` comparisons

pypa/cibuildwheel (+2 -0 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview

+ bin/bump_version.py:20:4: PYI066 Use `>=` when using `if`-`else` with `sys.version_info` comparisons
+ cibuildwheel/_compat/typing.py:5:4: PYI066 Use `>=` when using `if`-`else` with `sys.version_info` comparisons

pypa/setuptools (+4 -0 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview

+ setuptools/_importlib.py:3:4: PYI066 Use `>=` when using `if`-`else` with `sys.version_info` comparisons
+ setuptools/_importlib.py:9:4: PYI066 Use `>=` when using `if`-`else` with `sys.version_info` comparisons
+ setuptools/command/bdist_wheel.py:493:20: PYI066 Use `>=` when using `if`-`else` with `sys.version_info` comparisons
+ setuptools/tests/test_bdist_wheel.py:524:8: PYI066 Use `>=` when using `if`-`else` with `sys.version_info` comparisons

scikit-build/scikit-build-core (+19 -0 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview

+ docs/conf.py:16:4: PYI066 Use `>=` when using `if`-`else` with `sys.version_info` comparisons
+ src/scikit_build_core/_compat/builtins.py:5:4: PYI066 Use `>=` when using `if`-`else` with `sys.version_info` comparisons
+ src/scikit_build_core/_compat/importlib/metadata.py:15:8: PYI066 Use `>=` when using `if`-`else` with `sys.version_info` comparisons
+ src/scikit_build_core/_compat/importlib/metadata.py:17:10: PYI066 Use `>=` when using `if`-`else` with `sys.version_info` comparisons
+ src/scikit_build_core/_compat/importlib/metadata.py:6:4: PYI066 Use `>=` when using `if`-`else` with `sys.version_info` comparisons
+ src/scikit_build_core/_compat/importlib/resources.py:5:4: PYI066 Use `>=` when using `if`-`else` with `sys.version_info` comparisons
+ src/scikit_build_core/_compat/tomllib.py:5:4: PYI066 Use `>=` when using `if`-`else` with `sys.version_info` comparisons
+ src/scikit_build_core/_compat/typing.py:14:4: PYI066 Use `>=` when using `if`-`else` with `sys.version_info` comparisons
+ src/scikit_build_core/_compat/typing.py:19:4: PYI066 Use `>=` when using `if`-`else` with `sys.version_info` comparisons
+ src/scikit_build_core/_compat/typing.py:6:4: PYI066 Use `>=` when using `if`-`else` with `sys.version_info` comparisons
+ src/scikit_build_core/_logging.py:80:4: PYI066 Use `>=` when using `if`-`else` with `sys.version_info` comparisons
+ src/scikit_build_core/builder/sysconfig.py:179:8: PYI066 Use `>=` when using `if`-`else` with `sys.version_info` comparisons
+ src/scikit_build_core/file_api/reply.py:76:24: PYI066 Use `>=` when using `if`-`else` with `sys.version_info` comparisons
+ src/scikit_build_core/settings/json_schema.py:67:16: PYI066 Use `>=` when using `if`-`else` with `sys.version_info` comparisons
+ tests/conftest.py:16:4: PYI066 Use `>=` when using `if`-`else` with `sys.version_info` comparisons
+ tests/conftest.py:23:4: PYI066 Use `>=` when using `if`-`else` with `sys.version_info` comparisons
+ tests/packages/navigate_editable/python/shared_pkg/py_module.py:3:4: PYI066 Use `>=` when using `if`-`else` with `sys.version_info` comparisons
+ tests/test_builder.py:247:8: PYI066 Use `>=` when using `if`-`else` with `sys.version_info` comparisons
+ tests/test_pyproject_pep660.py:100:8: PYI066 Use `>=` when using `if`-`else` with `sys.version_info` comparisons

python-trio/trio (+7 -0 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview

+ src/trio/_core/_tests/test_run.py:2783:4: PYI006 Use `<` or `>=` for `sys.version_info` comparisons
+ src/trio/_tests/type_tests/path.py:110:8: PYI006 Use `<` or `>=` for `sys.version_info` comparisons
+ src/trio/_tests/type_tests/path.py:51:8: PYI006 Use `<` or `>=` for `sys.version_info` comparisons
+ src/trio/_tests/type_tests/path.py:57:8: PYI006 Use `<` or `>=` for `sys.version_info` comparisons
+ src/trio/_tests/type_tests/path.py:60:8: PYI006 Use `<` or `>=` for `sys.version_info` comparisons
+ src/trio/_tests/type_tests/path.py:78:8: PYI006 Use `<` or `>=` for `sys.version_info` comparisons
+ src/trio/_tests/type_tests/path.py:98:8: PYI006 Use `<` or `>=` for `sys.version_info` comparisons

pytest-dev/pytest (+6 -0 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview

+ src/_pytest/_code/code.py:699:16: PYI066 Use `>=` when using `if`-`else` with `sys.version_info` comparisons
+ src/_pytest/assertion/rewrite.py:299:16: PYI066 Use `>=` when using `if`-`else` with `sys.version_info` comparisons
+ src/_pytest/pathlib.py:41:4: PYI066 Use `>=` when using `if`-`else` with `sys.version_info` comparisons
+ testing/_py/test_local.py:21:12: PYI006 Use `<` or `>=` for `sys.version_info` comparisons
+ testing/code/test_excinfo.py:1771:8: PYI066 Use `>=` when using `if`-`else` with `sys.version_info` comparisons
+ testing/test_debugging.py:106:12: PYI066 Use `>=` when using `if`-`else` with `sys.version_info` comparisons

Changes by rule (2 rules affected)

code	total	+ violation	- violation	+ fix	- fix
PYI066	34	34	0	0	0
PYI006	8	8	0	0	0

charliermarsh · 2024-11-03T02:48:05Z

Thanks! We probably need to gate this under preview, since it's an expansion of the rule.

[flake8-pyi] - include all python file types for PYI006 and PYI066

630138b

diceroll123 requested a review from AlexWaygood as a code owner November 2, 2024 23:25

charliermarsh added rule Implementing or modifying a lint rule preview Related to preview mode features labels Nov 3, 2024

diceroll123 added 2 commits November 2, 2024 23:45

tweaks for preview

7497d44

woop, update snapshots

8595363

MichaReiser approved these changes Nov 3, 2024

View reviewed changes

MichaReiser merged commit f69712c into astral-sh:main Nov 3, 2024

BrewTestBot mentioned this pull request Nov 8, 2024

ruff 0.7.3 Homebrew/homebrew-core#197081

Merged

This was referenced Jan 8, 2025

[flake8-pyi] Stabilize: include all python file types for PYI006 #15340

Merged

PYI066: Decide if the rule should apply for sys.version_info checks in boolean expressions #15347

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[`flake8-pyi`] - include all python file types for `PYI006` and `PYI066`#14059

[`flake8-pyi`] - include all python file types for `PYI006` and `PYI066`#14059
MichaReiser merged 3 commits intoastral-sh:mainfrom
diceroll123:pyi006-and-pyi066-for-py-files

diceroll123 commented Nov 2, 2024

Uh oh!

github-actions bot commented Nov 2, 2024 •

edited

Loading

Uh oh!

charliermarsh commented Nov 3, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

diceroll123 commented Nov 2, 2024

Summary

Test Plan

Uh oh!

github-actions bot commented Nov 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

ruff-ecosystem results

Linter (stable)

Linter (preview)

Uh oh!

charliermarsh commented Nov 3, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions bot commented Nov 2, 2024 •

edited

Loading

`ruff-ecosystem` results