Skip to content

[flake8-bugbear] Tweak B905 message to not suggest setting parameter strict= to False#13656

Merged
AlexWaygood merged 2 commits intoastral-sh:mainfrom
qdegraaf:feat/b905message
Oct 7, 2024
Merged

[flake8-bugbear] Tweak B905 message to not suggest setting parameter strict= to False#13656
AlexWaygood merged 2 commits intoastral-sh:mainfrom
qdegraaf:feat/b905message

Conversation

@qdegraaf
Copy link
Copy Markdown
Contributor

@qdegraaf qdegraaf commented Oct 7, 2024

Summary

Tweaks the message of B905 to not contradict the B905 docs, leaves the autofix alone so as to avoid changing semantics or code behaviour. See also: #13581 (comment)

Test Plan

cargo test

Issue link

Closes: #13581

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 7, 2024

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Copy link
Copy Markdown
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@AlexWaygood AlexWaygood enabled auto-merge (squash) October 7, 2024 11:52
@AlexWaygood AlexWaygood added the rule Implementing or modifying a lint rule label Oct 7, 2024
@AlexWaygood AlexWaygood merged commit 646e413 into astral-sh:main Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rule Implementing or modifying a lint rule

Projects

None yet

Development

Successfully merging this pull request may close these issues.

B905's autofix sets strict=False, but the suggested fix is strict=True

2 participants