[refurb] implement hardcoded-string-charset (FURB156)#13530
Merged
MichaReiser merged 5 commits intoastral-sh:mainfrom Oct 7, 2024
Merged
[refurb] implement hardcoded-string-charset (FURB156)#13530MichaReiser merged 5 commits intoastral-sh:mainfrom
refurb] implement hardcoded-string-charset (FURB156)#13530MichaReiser merged 5 commits intoastral-sh:mainfrom
Conversation
c4cac13 to
40149a1
Compare
Contributor
|
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| FURB156 | 3 | 3 | 0 | 0 | 0 |
MichaReiser
reviewed
Sep 26, 2024
crates/ruff_linter/src/rules/refurb/rules/hardcoded_string_charset.rs
Outdated
Show resolved
Hide resolved
MichaReiser
requested changes
Sep 27, 2024
Member
MichaReiser
left a comment
There was a problem hiding this comment.
Thanks. This looks great.
I left a few smaller comments. It would also be great to add some documentation to Charset and bitset, considering that the representations are non-trivial and make some assumptions about how they're used.
crates/ruff_linter/src/rules/refurb/rules/hardcoded_string_charset.rs
Outdated
Show resolved
Hide resolved
crates/ruff_linter/src/rules/refurb/rules/hardcoded_string_charset.rs
Outdated
Show resolved
Hide resolved
crates/ruff_linter/src/rules/refurb/rules/hardcoded_string_charset.rs
Outdated
Show resolved
Hide resolved
crates/ruff_linter/src/rules/refurb/rules/hardcoded_string_charset.rs
Outdated
Show resolved
Hide resolved
40149a1 to
a4a585d
Compare
MichaReiser
approved these changes
Sep 27, 2024
Member
MichaReiser
left a comment
There was a problem hiding this comment.
Nice, thanks for following up. Let's add a test for when the expression is parenthesized to verify that the fix is correct (if not, take a look at parenthesized_range.
I also think that we may be able to remove the factory methods on AsciiCharSet and reduce them to just one.
crates/ruff_linter/src/rules/refurb/rules/hardcoded_string_charset.rs
Outdated
Show resolved
Hide resolved
b9b3b64 to
aa0a81a
Compare
MichaReiser
approved these changes
Oct 7, 2024
Member
MichaReiser
left a comment
There was a problem hiding this comment.
Nice thanks. This looks great!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implement
hardcoded-string-charset(FURB156)See:
Test Plan
cargo test