Add support for extensionless Python files for server#13326
Merged
dhruvmanila merged 1 commit intomainfrom Sep 11, 2024
Merged
Conversation
Contributor
|
MichaReiser
approved these changes
Sep 11, 2024
Member
MichaReiser
left a comment
There was a problem hiding this comment.
Thanks.
Checking all recognized python files seems like a sensible thing to me. My only concern is that the LSP and CLI now disagree on the file that need checking.
Member
Author
That's true but this behavior seems reasonable from an editor perspective because the client provides us this information. This is also a regression from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes: #12539
Test Plan
Screen.Recording.2024-09-11.at.11.32.32.mov